Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ketcher.getMolfile() stopped working for macro canvas with peptides #5634

Closed
AlexeyGirin opened this issue Oct 3, 2024 · 1 comment · Fixed by #5731 or #5750
Closed

ketcher.getMolfile() stopped working for macro canvas with peptides #5634

AlexeyGirin opened this issue Oct 3, 2024 · 1 comment · Fixed by #5731 or #5750
Assignees
@rrodionov91
Labels
bug Priority: High regression Issue was found during regression Snake mode Bucket: Snake mode related issues
Milestone
Ketcher 2.26.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macro - Snake mode
  2. Load from file: snake-mode-peptides.zip
    image
  3. Open console and run: ketcher.getMolfile()

Actual behavior
System throws exception
image
localhost-1727965119555.log

Expected behavior
No exception.
snake-mode-peptides-expected.zip

Versions

  • Ketcher Version 2.25.0-rc.2 Build at 2024-10-03; 12:06:08
  • Indigo Toolkit Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.90 (Official Build) (64-bit)
  • Win10
@AlexeyGirin AlexeyGirin added bug Priority: High regression Issue was found during regression Snake mode Bucket: Snake mode related issues labels Oct 3, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.26.0-rc.2 milestone Oct 3, 2024
@rrodionov91 rrodionov91 self-assigned this Oct 10, 2024
rrodionov91 added a commit that referenced this issue Oct 11, 2024
@rrodionov91
#5634 - ketcher.getMolfile() stopped working for macro canvas with pe…
a24bd21 
…ptides
@rrodionov91 rrodionov91 linked a pull request Oct 11, 2024 that will close this issue
#5634 - ketcher.getMolfile() stopped working for macro canvas with peptides #5731
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 13, 2024
@rrodionov91
#5634 - ketcher.getMolfile() stopped working for macro canvas with pe…
49f5b8a 
…ptides
rrodionov91 added a commit that referenced this issue Oct 13, 2024
@rrodionov91
#5634 - ketcher.getMolfile() stopped working for macro canvas with pe…
1c4bd6c 
…ptides
rrodionov91 added a commit that referenced this issue Oct 13, 2024
@rrodionov91
#5634 - ketcher.getMolfile() stopped working for macro canvas with pe…
637bb1b 
…ptides
This was referenced Oct 14, 2024
Open
Closed
rrodionov91 added a commit that referenced this issue Oct 14, 2024
@rrodionov91
#5634 - ketcher.getMolfile() stopped working for macro canvas with pe…
994ac34 
…ptides (#5731)
rrodionov91 added a commit that referenced this issue Oct 14, 2024
@rrodionov91
#5634 - ketcher.getMolfile() stopped working for macro canvas with pe…
9d169f6 
…ptides
@rrodionov91 rrodionov91 linked a pull request Oct 14, 2024 that will close this issue
Backmerge: #5634 - ketcher.getMolfile() stopped working for macro canvas with peptides #5750
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 15, 2024
@rrodionov91
#5634 - ketcher.getMolfile() stopped working for macro canvas with pe…
92515fa 
…ptides
@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.

2024-10-15_15h54_58

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.2]
Indigo version
[Version 1.25.0-rc.2]

rrodionov91 added a commit that referenced this issue Oct 16, 2024
@rrodionov91
Backmerge: #5634 - ketcher.getMolfile() stopped working for macro can…
433eb52 
…vas with peptides (#5750)
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
Backmerge: #5634 - ketcher.getMolfile() stopped working for macro can…
f51d1af 
…vas with peptides (#5750)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: High regression Issue was found during regression Snake mode Bucket: Snake mode related issues
Projects
None yet
Milestone
Ketcher 2.26.0-rc.2
3 participants
@rrodionov91 @AlexeyGirin @Zhirnoff