Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The diagonal bond in the molecule is displayed incorrect with ACS style #5685

Closed
AnnaKosol opened this issue Oct 7, 2024 · 2 comments · Fixed by #5738, #5787, #5801, #5803 or #5850
Closed

The diagonal bond in the molecule is displayed incorrect with ACS style #5685

AnnaKosol opened this issue Oct 7, 2024 · 2 comments · Fixed by #5738, #5787, #5801, #5803 or #5850
Assignees
@Guch1g0v
Labels
ACS standard bug Priority: Medium Team G
Milestone
Ketcher 2.26.0-rc.7

Comments

@AnnaKosol
Copy link
Contributor

AnnaKosol commented Oct 7, 2024 •
edited
Loading

Steps to Reproduce

  1. add to the Canvas
Screenshot 2024-10-07 at 13 28 52

The diagonal bond in the molecule is displayed incorrect with ACS style.ket.zip

  1. click on ACS style button in the Settings
  2. click on Apply button

Actual behavior
Screenshot 2024-10-07 at 13 49 29

Expected behavior
the molecule is displayed with space between parts
Image

Environment details:

  • Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
  • Indigo Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
  • MacOs
  • Chrome 129.0.6668.71 (Official Build) (arm64)

Issues found while testing epam/Indigo#2175
@AnnaKosol AnnaKosol transferred this issue from epam/Indigo Oct 8, 2024
@AnnaKosol AnnaKosol added this to the Ketcher 2.26.0-rc.2 milestone Oct 8, 2024
Guch1g0v added a commit that referenced this issue Oct 14, 2024
@Guch1g0v
#5685 - The diagonal bond in the molecule is displayed incorrect with…
30bea12 
… ACS style
@Guch1g0v Guch1g0v linked a pull request Oct 14, 2024 that will close this issue
Backmerge: #5685 - The diagonal bond in the molecule is displayed incorrect with ACS style #5738
Merged
9 tasks
@Guch1g0v Guch1g0v removed a link to a pull request Oct 14, 2024
Backmerge: #5685 - The diagonal bond in the molecule is displayed incorrect with ACS style #5738
Merged
9 tasks
@Guch1g0v Guch1g0v linked a pull request Oct 14, 2024 that will close this issue
Backmerge: #5685 - The diagonal bond in the molecule is displayed incorrect with ACS style #5738
Merged
9 tasks
Guch1g0v added a commit that referenced this issue Oct 14, 2024
@Guch1g0v
#5685 - The diagonal bond in the molecule is displayed incorrect with…
f43176c 
… ACS style
NataliaLoginova pushed a commit that referenced this issue Oct 16, 2024
@Guch1g0v @AlexeyGirin
Backmerge: #5685 - The diagonal bond in the molecule is displayed inc…
56841a2 
…orrect with ACS style (#5738)

* #5685 - The diagonal bond in the molecule is displayed incorrect with ACS style

* update snapshots

* update snapshots

---------

Co-authored-by: Alexey Girin <agirin@mail.ru>
Guch1g0v added a commit that referenced this issue Oct 16, 2024
@Guch1g0v
#5685 - The diagonal bond in the molecule is displayed incorrect with…
37b4bc3 
… ACS style
@Guch1g0v Guch1g0v linked a pull request Oct 16, 2024 that will close this issue
#5685 - The diagonal bond in the molecule is displayed incorrect with ACS style #5777
Closed
9 tasks
Guch1g0v added a commit that referenced this issue Oct 16, 2024
@Guch1g0v
#5685 - The diagonal bond in the molecule is displayed incorrect with…
2b4658c 
… ACS style
@Guch1g0v Guch1g0v linked a pull request Oct 16, 2024 that will close this issue
#5685 - The diagonal bond in the molecule is displayed incorrect with ACS style #5787
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Oct 17, 2024
@Guch1g0v
#5685 - The diagonal bond in the molecule is displayed incorrect with…
72172ab 
… ACS style (#5787)
Guch1g0v added a commit that referenced this issue Oct 17, 2024
@Guch1g0v @AlexeyGirin
Backmerge: #5685 - The diagonal bond in the molecule is displayed inc…
5791279 
…orrect with ACS style (#5738)

* #5685 - The diagonal bond in the molecule is displayed incorrect with ACS style

* update snapshots

* update snapshots

---------

Co-authored-by: Alexey Girin <agirin@mail.ru>
@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Oct 17, 2024 •
edited
Loading

Rollback this changes!
It is not allowed to fix bug by changing default parameters

@AlexeyGirin AlexeyGirin reopened this Oct 17, 2024
Guch1g0v added a commit that referenced this issue Oct 17, 2024
@Guch1g0v
Revert "Backmerge: #5685 - The diagonal bond in the molecule is displ…
ee9bfa5 
…ayed incorrect with ACS style (#5738)"

This reverts commit 56841a2.
Guch1g0v added a commit that referenced this issue Oct 17, 2024
@Guch1g0v
Revert "#5685 - The diagonal bond in the molecule is displayed incorr…
12c96a5 
…ect with ACS style (#5787)"

This reverts commit 72172ab.
svvald pushed a commit that referenced this issue Oct 17, 2024
@Guch1g0v
Revert "#5685 - The diagonal bond in the molecule is displayed incorr…
6e61789 
…ect with ACS style (#5787)" (#5803)

This reverts commit 72172ab.
NataliaLoginova pushed a commit that referenced this issue Oct 18, 2024
@Guch1g0v
Revert: Backmerge: #5685 - The diagonal bond in the molecule is displ…
aa5fc42 
…ayed incorrect with ACS style (#5738) (#5801)

* Revert "Backmerge: #5685 - The diagonal bond in the molecule is displayed incorrect with ACS style (#5738)"

This reverts commit 56841a2.

* fix: tests
@NataliaLoginova NataliaLoginova removed a link to a pull request Oct 21, 2024
#5685 - The diagonal bond in the molecule is displayed incorrect with ACS style #5777
Closed
9 tasks
This was linked to pull requests Oct 22, 2024
Revert: Backmerge: #5685 - The diagonal bond in the molecule is displayed incorrect with ACS style (#5738) #5801
Merged
Revert: #5685 - The diagonal bond in the molecule is displayed incorrect with ACS style (#5787) #5803
Merged
Guch1g0v added a commit that referenced this issue Oct 24, 2024
@Guch1g0v
#5685 - The diagonal bond in the molecule is displayed incorrect with…
f650479 
… ACS style
@Guch1g0v Guch1g0v linked a pull request Oct 24, 2024 that will close this issue
#5685 - The diagonal bond in the molecule is displayed incorrect with ACS style #5850
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Oct 28, 2024
@Guch1g0v
#5685 - The diagonal bond in the molecule is displayed incorrect with…
559630b 
… ACS style (#5850)
Guch1g0v added a commit that referenced this issue Oct 28, 2024
@Guch1g0v
#5685 - The diagonal bond in the molecule is displayed incorrect with…
4e3b8f0 
… ACS style
@Guch1g0v Guch1g0v linked a pull request Oct 28, 2024 that will close this issue
Backmerge: #5685 - The diagonal bond in the molecule is displayed incorrect with ACS style #5875
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Oct 28, 2024
@Guch1g0v
#5685 - The diagonal bond in the molecule is displayed incorrect with…
4364600 
… ACS style (#5875)
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Nov 4, 2024

Tested. Bug fixed.
2024-11-04_17h57_26

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.7]
Indigo version
[Version 1.25.0-rc.4]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guch1g0v Guch1g0v

Labels
ACS standard bug Priority: Medium Team G
Projects
None yet
Milestone
Ketcher 2.26.0-rc.7
6 participants
@svvald @rrodionov91 @AlexeyGirin @Zhirnoff @Guch1g0v @AnnaKosol