Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backmerge: #5685 - The diagonal bond in the molecule is displayed incorrect with ACS style #5738

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Backmerge: #5685 - The diagonal bond in the molecule is displayed incorrect with ACS style #5738

merged 6 commits into from
Oct 16, 2024

Conversation

Guch1g0v
Copy link
Collaborator

@Guch1g0v Guch1g0v commented Oct 14, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)
Fix default constant responsible for bond's length

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@Guch1g0v Guch1g0v linked an issue Oct 14, 2024 that may be closed by this pull request
The diagonal bond in the molecule is displayed incorrect with ACS style #5685
Closed
@Guch1g0v Guch1g0v removed a link to an issue Oct 14, 2024
The diagonal bond in the molecule is displayed incorrect with ACS style #5685
Closed
@Guch1g0v Guch1g0v linked an issue Oct 14, 2024 that may be closed by this pull request
The diagonal bond in the molecule is displayed incorrect with ACS style #5685
Closed
@Guch1g0v Guch1g0v force-pushed the 5685-the-diagonal-bond-in-the-molecule-is-displayed-incorrect-with-acs-style branch from 30bea12 to f43176c Compare October 14, 2024 12:59
@NataliaLoginova NataliaLoginova changed the title #5685 - The diagonal bond in the molecule is displayed incorrect with ACS style Backmerge: #5685 - The diagonal bond in the molecule is displayed incorrect with ACS style Oct 15, 2024
AlexeyGirin
AlexeyGirin approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@AlexeyGirin AlexeyGirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots are correct

@AlexeyGirin
Merge branch 'master' of https://github.com/epam/ketcher into 5685-th…
cfb5884 
…e-diagonal-bond-in-the-molecule-is-displayed-incorrect-with-acs-style
@NataliaLoginova NataliaLoginova merged commit 56841a2 into master Oct 16, 2024
5 checks passed
@NataliaLoginova NataliaLoginova deleted the 5685-the-diagonal-bond-in-the-molecule-is-displayed-incorrect-with-acs-style branch October 16, 2024 10:49
Guch1g0v added a commit that referenced this pull request Oct 17, 2024
@Guch1g0v @AlexeyGirin
Backmerge: #5685 - The diagonal bond in the molecule is displayed inc…
5791279 
…orrect with ACS style (#5738)

* #5685 - The diagonal bond in the molecule is displayed incorrect with ACS style

* update snapshots

* update snapshots

---------

Co-authored-by: Alexey Girin <agirin@mail.ru>
Guch1g0v added a commit that referenced this pull request Oct 17, 2024
@Guch1g0v
Revert "Backmerge: #5685 - The diagonal bond in the molecule is displ…
ee9bfa5 
…ayed incorrect with ACS style (#5738)"

This reverts commit 56841a2.
NataliaLoginova pushed a commit that referenced this pull request Oct 18, 2024
@Guch1g0v
Revert: Backmerge: #5685 - The diagonal bond in the molecule is displ…
aa5fc42 
…ayed incorrect with ACS style (#5738) (#5801)

* Revert "Backmerge: #5685 - The diagonal bond in the molecule is displayed incorrect with ACS style (#5738)"

This reverts commit 56841a2.

* fix: tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zhirnoff Zhirnoff Zhirnoff approved these changes

@AlexeyGirin AlexeyGirin AlexeyGirin approved these changes

@NataliaLoginova NataliaLoginova NataliaLoginova approved these changes

@svvald svvald Awaiting requested review from svvald

Assignees

@Guch1g0v Guch1g0v

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The diagonal bond in the molecule is displayed incorrect with ACS style
4 participants
@Guch1g0v @NataliaLoginova @AlexeyGirin @Zhirnoff