Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to load variant sugar from HELM - system throws an error: Convert error! {} #5709

Closed
AlexeyGirin opened this issue Oct 3, 2024 · 1 comment · Fixed by #5716 or #5732
Closed

Unable to load variant sugar from HELM - system throws an error: Convert error! {} #5709

AlexeyGirin opened this issue Oct 3, 2024 · 1 comment · Fixed by #5716 or #5732
Assignees
@rrodionov91
Labels
bug Flex mode Bucket: Flex canvas related mode HELM Bucket: Bugs related to Export to HELM format Priority: Medium
Milestone
Ketcher 2.26.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Oct 3, 2024 •
edited
Loading

Steps to Reproduce

  1. Toggle to Macro - Flex
  2. Load using paste from clipboard way following HELM: RNA1{([25d3r],[25mo3r])(A)P}$$$$V2.0
    image

Actual behavior
System throws an error: Convert error! {}
image
and single sugar appears on the canvas (with APs occupied but with no phosphate and base)
image

Expected behavior
No exception. Preset appears on the canvas
image

Versions

  • Ketcher Version 2.25.0-rc.4 Build at 2024-09-23; 17:24:38
  • Indigo Toolkit Version 1.24.0-rc.3.0-g692080c62-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.59 (Official Build) (64-bit)
  • Win10

Reference issues: epam/Indigo#2188, #4554
@AlexeyGirin AlexeyGirin added bug Priority: Medium Flex mode Bucket: Flex canvas related mode HELM Bucket: Bugs related to Export to HELM format labels Oct 3, 2024
@AlexeyGirin AlexeyGirin transferred this issue from epam/Indigo Oct 10, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.26.0-rc.2 milestone Oct 10, 2024
@rrodionov91 rrodionov91 self-assigned this Oct 10, 2024
rrodionov91 added a commit that referenced this issue Oct 10, 2024
@rrodionov91
#5709 - Unable to load variant sugar from HELM - system throws an err…
7eeeedc 
…or: Convert error! {}

- fixed sugar/phosphate/chem variant monomers render
@rrodionov91 rrodionov91 linked a pull request Oct 10, 2024 that will close this issue
#5709 - Unable to load variant sugar from HELM - system throws an error: Convert error! {} #5716
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 11, 2024
@rrodionov91
#5709 - Unable to load variant sugar from HELM - system throws an err…
318564f 
…or: Convert error! {} (#5716)

- fixed sugar/phosphate/chem variant monomers render
- fixed tests
rrodionov91 added a commit that referenced this issue Oct 11, 2024
@rrodionov91
#5709 - Unable to load variant sugar from HELM - system throws an err…
206e829 
…or: Convert error! {}

- fixed sugar/phosphate/chem variant monomers render
@rrodionov91 rrodionov91 linked a pull request Oct 11, 2024 that will close this issue
Backmerge: #5709 - Unable to load variant sugar from HELM - system throws an error: Convert error! {} #5732
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 13, 2024
@rrodionov91
Backmerge: #5709 - Unable to load variant sugar from HELM - system th…
5d7f256 
…rows an error: Convert error! {} (#5732)

- fixed sugar/phosphate/chem variant monomers render
rrodionov91 added a commit that referenced this issue Oct 13, 2024
@rrodionov91
Backmerge: #5709 - Unable to load variant sugar from HELM - system th…
b327c22 
…rows an error: Convert error! {} (#5732)

- fixed sugar/phosphate/chem variant monomers render
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

  • Ketcher Version 2.26.0-rc.2 Build at 2024-10-14; 19:59:03
  • Indigo Toolkit Version 1.25.0-rc.2.0-g867ae250b-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)
  • Win10

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
Backmerge: #5709 - Unable to load variant sugar from HELM - system th…
e9b9f97 
…rows an error: Convert error! {} (#5732)

- fixed sugar/phosphate/chem variant monomers render
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Flex mode Bucket: Flex canvas related mode HELM Bucket: Bugs related to Export to HELM format Priority: Medium
Projects
None yet
Milestone
Ketcher 2.26.0-rc.2
2 participants
@rrodionov91 @AlexeyGirin