Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5709 - Unable to load variant sugar from HELM - system throws an error: Convert error! {} #5716

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Oct 10, 2024

How the feature works? / How did you fix the issue?

  • fixed sugar/phosphate/chem variant monomers render

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

…or: Convert error! {}

- fixed sugar/phosphate/chem variant monomers render
@@ -15,6 +15,7 @@ export const MONOMER_SYMBOLS_IDS = {
hover: '#sugar-selection',
selected: '#sugar-selection',
body: '#sugar',
variant: '#sugar-variant',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to use ambiguous here to avoid ambiguity (hehe) between variant and ambiguous in our code?

@rrodionov91 rrodionov91 merged commit 318564f into release/2.26 Oct 11, 2024
3 checks passed
@rrodionov91 rrodionov91 deleted the 5709-Unable_to_load_variant_sugar_from_HELM_-_system_throws_an_error_Convert_error! branch October 11, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants