-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minimal distances for mult-tail validation in KET format #5761
Labels
MMPK
Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes
Multi-Tailed Arrow Tool
Priority: High
Milestone
Comments
This was referenced Oct 15, 2024
daniil-sloboda
added a commit
that referenced
this issue
Oct 16, 2024
9 tasks
daniil-sloboda
added a commit
that referenced
this issue
Oct 16, 2024
rrodionov91
pushed a commit
that referenced
this issue
Oct 16, 2024
- updated minimal ket validation distance - commented tests with minimal values because they are no longer valid
daniil-sloboda
added a commit
that referenced
this issue
Oct 16, 2024
- updated minimal ket validation distance - commented tests with minimal values because they are no longer valid
9 tasks
12 manual tests and files are updated, minimal sizes are retested on UI and for loading from KET on Nightly env.
|
Guch1g0v
pushed a commit
that referenced
this issue
Oct 17, 2024
- updated minimal ket validation distance - commented tests with minimal values because they are no longer valid
Need merge into 2.26 |
rrodionov91
pushed a commit
that referenced
this issue
Oct 21, 2024
- updated minimal ket validation distance - commented tests with minimal values because they are no longer valid
rrodionov91
pushed a commit
that referenced
this issue
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
MMPK
Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes
Multi-Tailed Arrow Tool
Priority: High
Steps to Reproduce
Actual behavior
Error message appears - cannot deserialize input JSON
Expected behavior
No errors, Structure is pasted but with a smaller size
The following validation rules should be changed for KET file (only for KET, the UI behavior should not be changed)
MIN_TAIL_DISTANCE - 0.01.
MIN_HEAD_LENGTH - 0.01.
MIN_TAIL_LENGTH - 0.01
MIN_TOP_BOTTOM_OFFSET - 0.01
MIN_HEIGHT - 0.01
Desktop (please complete the following information):
Note
The text was updated successfully, but these errors were encountered: