Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught TypeError is in console when trying to move tail of Multi-Tailed Arrow added from KET with small size between tails #5786

Closed
ivanmaslow opened this issue Oct 16, 2024 · 2 comments · Fixed by #5806 or #5837
Closed

Uncaught TypeError is in console when trying to move tail of Multi-Tailed Arrow added from KET with small size between tails #5786

ivanmaslow opened this issue Oct 16, 2024 · 2 comments · Fixed by #5806 or #5837
Assignees
@daniil-sloboda
Labels
bug MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Multi-Tailed Arrow Tool Priority: Medium
Milestone
Ketcher 2.26.0-rc.6

Comments

@ivanmaslow
Copy link
Collaborator

Steps to Reproduce

  1. Load Multi-Tailed Arrow from KET
    multi-tailed-arrow-4-tails-minimal-distance.zip
    image
  2. Try to move the middle tails which are intersected with the top and bottom tails because of the distance = 0.01

Actual behavior

  • Tail is moved to the nearest available place, "TypeError Cannot read properties of undefined (reading 'center')" appears in the console:
    image

Expected behavior
No issues in console, MTA should be automatically expanded to a minimal size on the UI
TBD - Confirm with PO

Environment Details

  • Tested on Nightly env
  • Ketcher [Version 2.26.0-rc.1] Build at 2024-10-16; 06:55:14
  • Indigo Version 1.26.0-dev.1.0-g2edd615c1-wasm32-wasm-clang-19.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)

Additional context
@ivanmaslow ivanmaslow added bug Priority: Medium MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Multi-Tailed Arrow Tool labels Oct 16, 2024
@ivanmaslow ivanmaslow added this to the Ketcher 2.26.0-rc.4 milestone Oct 16, 2024
@ivanmaslow ivanmaslow mentioned this issue Oct 16, 2024
Closed
@daniil-sloboda daniil-sloboda self-assigned this Oct 17, 2024
@daniil-sloboda daniil-sloboda linked a pull request Oct 18, 2024 that will close this issue
Backmerge: #5753 - Fixed issue with tail normalization when moving #5806
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Oct 18, 2024
@daniil-sloboda
Backmerge: #5753 - Fixed issue with tail normalization when moving (#…
631993d 
…5806)

#5786 - Uncaught TypeError is in console when trying to move tail of Multi-Tailed Arrow added from KET with small size between tails
#5776 - Add API Method getRdf for retrieving RDF representation of structures
#5753 - Issue with moving of tail of Multi-Tailed arrow with several tails when user needs to move the tail close to another one
@rrodionov91
Copy link
Collaborator

Need merge into 2.26

@rrodionov91 rrodionov91 reopened this Oct 18, 2024
daniil-sloboda added a commit that referenced this issue Oct 22, 2024
@daniil-sloboda
Backmerge: #5753 - Fixed issue with tail normalization when moving (#…
25d0bf7 
…5806)

#5786 - Uncaught TypeError is in console when trying to move tail of Multi-Tailed Arrow added from KET with small size between tails
#5776 - Add API Method getRdf for retrieving RDF representation of structures
#5753 - Issue with moving of tail of Multi-Tailed arrow with several tails when user needs to move the tail close to another one
@daniil-sloboda daniil-sloboda linked a pull request Oct 22, 2024 that will close this issue
#5753 - Issue with moving of tail of Multi-Tailed arrow with several tails when user needs to move the tail close to another one #5837
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Oct 22, 2024
@daniil-sloboda
#5753 - Issue with moving of tail of Multi-Tailed arrow with several …
0367370 
…tails when user needs to move the tail close to another one

#5413 - Fixed sizeless svg issue
#5786 - Uncaught TypeError is in console when trying to move tail of Multi-Tailed Arrow added from KET with small size between tails
#5776 - Add API Method getRdf for retrieving RDF representation of structures
#5753 - Issue with moving of tail of Multi-Tailed arrow with several tails when user needs to move the tail close to another one
@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.

2024-10-25_14h32_56.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.6]
Indigo version
[Version 1.25.0-rc.4]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniil-sloboda daniil-sloboda

Labels
bug MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Multi-Tailed Arrow Tool Priority: Medium
Projects
None yet
Milestone
Ketcher 2.26.0-rc.6
6 participants
@svvald @rrodionov91 @AlexeyGirin @Zhirnoff @ivanmaslow @daniil-sloboda