Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backmerge: #5753 - Fixed issue with tail normalization when moving #5806

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

daniil-sloboda
Copy link
Collaborator

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@@ -263,6 +263,17 @@ export class Ketcher {
return getStructure(format, this.#formatterFactory, this.#editor.struct());
}

getRdf(molfileFormat: MolfileFormat = 'v2000'): Promise<string> {
if (window.isPolymerEditorTurnedOn) {
throw new Error('SDF format is not available in macro mode');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a typo here? Should it be RDF instead of SDF?

@rrodionov91 rrodionov91 changed the title #5753: Fixed issue with tail normalization when moving Backmerge: #5753 - Fixed issue with tail normalization when moving Oct 18, 2024
@rrodionov91 rrodionov91 merged commit 631993d into master Oct 18, 2024
5 checks passed
@rrodionov91 rrodionov91 deleted the 5753-multitail-move-tail-fix branch October 18, 2024 12:31
daniil-sloboda added a commit that referenced this pull request Oct 22, 2024
…5806)

#5786 - Uncaught TypeError is in console when trying to move tail of Multi-Tailed Arrow added from KET with small size between tails
#5776 - Add API Method getRdf for retrieving RDF representation of structures
#5753 - Issue with moving of tail of Multi-Tailed arrow with several tails when user needs to move the tail close to another one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants