#2043 thumbnail images are not readable in template dialog #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issue with ForwardedRef type
…-template-dialog
| ) - 0 | ||
| : Number( | ||
| ((value * measureMap[measureFrom]) / measureMap[measureTo]).toFixed(3) | ||
| ) - 0 |
There was a problem hiding this comment.
Looks like these two lines only differ in that the second one uses "toFixed(3)" - maybe we could put this into a separate function? e.g. getFormatedValue or something like that?
| options={{ | ||
| ...options, | ||
| autoScaleMargin: 15, | ||
| fontsz: 55, |
There was a problem hiding this comment.
could we put these into constants, since it looks like these are re-used in several files?
…-template-dialog
…tion for MeasureInput formatted value
…inside Render update method
…-template-dialog
|
@porcelain11 I went in a slightly different direction with this: #2098 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change font size, bondThickness and doubleBondWidth separately for Salts&Salvents and rest templates (main changes are in the last but one commit )
Rename some files to .tsx and add types (tried to fix the issue with ForwardedRef type )