#2043: Thumbnail images are not readable in Template Dialog #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an updated version of the following PR: #2063 |
| @@ -41,9 +40,9 @@ interface TemplateTableProps { | |||
| onDelete?: (tmpl: Template) => void | |||
| onAttach?: (tmpl: Template) => void | |||
| titleRows?: 1 | 2 | |||
| renderOptions?: any | |||
There was a problem hiding this comment.
is it possible to add a type shape for a renderOptions?
There was a problem hiding this comment.
we don't have one now, I think we can add that as a separate refactor ticket for the future
Nitvex
approved these changes
Jan 18, 2023
KonstantinEpam23
deleted the
2043-thumbnail-images-are-not-readable-in-template-dialog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2043