Macro: #3041 – RNA Builder. Delete presets. #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
OlgaMazurina,
SashaGraves and
ViktoriaTkacheva
StarlaStarla
changed the title
OlgaMazurina
reviewed
Oct 9, 2023
| await takePageScreenshot(page); | ||
| }); | ||
|
|
||
| test.skip('Delete copy RNA preset', async ({ page }) => { |
There was a problem hiding this comment.
Because I saw this in the README.md
There was a problem hiding this comment.
@rrodionov91 Is it up-to-date information?
There was a problem hiding this comment.
@OlgaMazurina , @StarlaStarla it is old information. Currently tests are running on CI also, so we don't need to skip it. Please also remove this info from readme
| await waitForPageInit(page); | ||
| await gotoRNA(page); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Let's add here test.afterEach:
await test.afterEach(async ({ page }) => {
await takePageScreenshot(page);
});
StarlaStarla
force-pushed
the
3041-rna-builder-delete-presets
branch
from
f3599cd to
e243fdb
Compare
ViktoriaTkacheva
approved these changes
Oct 10, 2023
OlgaMazurina
approved these changes
Oct 11, 2023
StarlaStarla
force-pushed
the
3041-rna-builder-delete-presets
branch
from
537c5ec to
2711c70
Compare
rrodionov91
approved these changes
Oct 13, 2023
Nitvex
changed the title
SashaGraves
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name