Fixes for ImGuiModFlags_XXX -> ImGuiMod_XXX (v1.89) (#347) #407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #347 and an update following this change in core lib:
ocornut/imgui@fd408c9
Like with #347 this is only required for users building with
IMGUI_DISABLE_OBSOLETE_FUNCTIONS
+ aiming to support a few older versions.If you don't mind raising minimum imgui version to latest, you can start taking advantage of the fact that ImGuiMod_XXX values can be safely or-ed with an ImGuiKey, so stuff like:
Could become:
(adding Ctrl for the example but PanMod default to None).
I would however suggest not making those changes yet, wait until at least 1.89 releases.