Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RFDIV macro #58

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix RFDIV macro #58

merged 1 commit into from
Oct 12, 2023

Conversation

ZanMaticPratnemer
Copy link
Contributor

evgEvtClk.db uses a RFIDV macro instead of FDIV.

@jerzyjamroz
Copy link
Contributor

@ZanMaticPratnemer

mrfioc2/evgMrmApp/Db/evgEvtClk.db

Line 87 in 5599ea6

field( VAL, "$(RFDIV=4)")

Correct, would you prefer to change it in the subs files or in the evgEvtClk.db directly?

@jerzyjamroz jerzyjamroz self-assigned this Oct 12, 2023
@jerzyjamroz jerzyjamroz self-requested a review October 12, 2023 10:34
@zioven
Copy link
Contributor

zioven commented Oct 12, 2023

I would argue that this should be done in the .subs file as it describes functionality of the EVM (RF divider)

@jerzyjamroz jerzyjamroz merged commit 57cee32 into epics-modules:master Oct 12, 2023
11 checks passed
@zioven zioven deleted the fix-rfdiv-macro branch December 15, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerzyjamroz jerzyjamroz Awaiting requested review from jerzyjamroz jerzyjamroz is a code owner

Assignees

@jerzyjamroz jerzyjamroz

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZanMaticPratnemer @jerzyjamroz @zioven