Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct package name in license files #113

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Use correct package name in license files #113

merged 2 commits into from
Dec 5, 2023

Conversation

joshwlambert
Copy link
Member

The license files (LICENSE and LICENSE.md) were stating the copyright to the {readepi} authors. This PR updates the license files to specify the copyright holder is the {packagetemplate} authors.

I initially noticed this when updating a package that derived from {packagetemplate}. I had replaced all instances of "packagetemplate" but had missed these as I did not do a full package search of "readepi". This PR removes the last instances of "readepi" from {packagetemplate}.

@Bisaloo
Copy link
Member

Bisaloo commented Dec 5, 2023

Can we use "the package authors" instead so that it kind of works even if not properly updated in packages using the template?

@joshwlambert
Copy link
Member Author

We could add a point to the release_bullets() to remind maintainers to update the license in their package. However, this is only needed in the first release so I will not add it for now. If you think it should be included feel free to add before merging.

@Bisaloo
Copy link
Member

Bisaloo commented Dec 5, 2023

Thanks! I have added it as a reminder in epiverse-trace/etdev#5 once we can move forward with this issue.

@Bisaloo Bisaloo merged commit 65b9833 into main Dec 5, 2023
7 checks passed
@Bisaloo Bisaloo deleted the license branch December 5, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants