-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release candidate v3.43.0 #360
Conversation
…vices, to ease last.fm integration
…up all queries (ex. sort artists by last write)
…Artist. But this is really best effort as it is way too long
…This made DSub behave badly. fixes #356
@@ -68,7 +87,7 @@ | |||
LMS_LOG(DB, INFO) << "Creating connection pool on file " << dbPath.string(); | |||
|
|||
auto connection{ std::make_unique<Connection>(dbPath.string()) }; | |||
// connection->setProperty("show-queries", "true"); | |||
// connection->setProperty("show-queries", "true"); |
Check notice
Code scanning / CodeQL
Commented-out code Note
namespace | ||
{ | ||
template <typename ResultType> | ||
Wt::Dbo::Query<ResultType> createQuery(Session& session, std::string_view itemToSelect, const Artist::FindParameters& params) |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
|| params.dateRange | ||
|| params.artist.isValid()) | ||
template <typename ResultType> | ||
Wt::Dbo::Query<ResultType> createQuery(Session& session, std::string_view itemToSelect, const Release::FindParameters& params) |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
namespace | ||
{ | ||
template <typename ResultType> | ||
Wt::Dbo::Query<ResultType> createQuery(Session& session, std::string_view itemToSelect, const Track::FindParameters& params) |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
addEntry(tracklistEntry); | ||
} | ||
|
||
void PlayQueue::addEntry(const Database::TrackListEntry::pointer& tracklistEntry) |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
}; | ||
} | ||
|
||
PlayQueue::PlayQueue() |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
refreshView(); | ||
} | ||
|
||
void Artist::refreshView() |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
No description provided.