Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate v3.43.0 #360

Merged
merged 28 commits into from
Nov 4, 2023
Merged

Release candidate v3.43.0 #360

merged 28 commits into from
Nov 4, 2023

Conversation

epoupon
Copy link
Owner

@epoupon epoupon commented Nov 3, 2023

No description provided.

…up all queries (ex. sort artists by last write)
…Artist. But this is really best effort as it is way too long
@@ -68,7 +87,7 @@
LMS_LOG(DB, INFO) << "Creating connection pool on file " << dbPath.string();

auto connection{ std::make_unique<Connection>(dbPath.string()) };
// connection->setProperty("show-queries", "true");
// connection->setProperty("show-queries", "true");

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
src/libs/services/database/impl/Track.cpp Dismissed Show dismissed Hide dismissed
src/libs/services/database/impl/Track.cpp Dismissed Show dismissed Hide dismissed
src/libs/services/database/impl/Track.cpp Fixed Show fixed Hide fixed
namespace
{
template <typename ResultType>
Wt::Dbo::Query<ResultType> createQuery(Session& session, std::string_view itemToSelect, const Artist::FindParameters& params)

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 109 lines.
|| params.dateRange
|| params.artist.isValid())
template <typename ResultType>
Wt::Dbo::Query<ResultType> createQuery(Session& session, std::string_view itemToSelect, const Release::FindParameters& params)

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 147 lines.
namespace
{
template <typename ResultType>
Wt::Dbo::Query<ResultType> createQuery(Session& session, std::string_view itemToSelect, const Track::FindParameters& params)

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 131 lines.
addEntry(tracklistEntry);
}

void PlayQueue::addEntry(const Database::TrackListEntry::pointer& tracklistEntry)

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 104 lines.
};
}

PlayQueue::PlayQueue()

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 118 lines.
refreshView();
}

void Artist::refreshView()

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 101 lines.
@epoupon epoupon merged commit 89a9878 into master Nov 4, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant