Release candidate v3.43.0

README.md

@@ -4,7 +4,7 @@
 
 _LMS_ is a self-hosted music streaming software: access your music collection from anywhere using a web interface!
 
-A [demo instance](http://lms-demo.poupon.dev) is available. Note the administration panel is not available.
+A [demo instance](http://lms-demo.poupon.dev) is available. Note the administration settings are not available.
 
 ## Main features
 * Recommendation engine
@@ -34,12 +34,14 @@ _LMS_ provides several ways to help you find the music you like:
   * Starred _Jazz_ albums
   * ...
 
+__Note__: depending on your database size and/or your hardware, the tag-based recommendation engine may significantly slow down the user interface. You can disable it in the administration settings.
+
 ## About tags
 _LMS_ relies exclusively on tags to organize your music collection.
 
 ### Filtering
 You can specify the tags you want to use to filter your collection. By default, `genre`, `albumgrouping`, `mood` and `albummood` tags are used.
-In the administration  panel, you can set whatever tags you want, even custom tags.
+In the administration settings, you can set whatever tags you want, even custom tags.
 
 __Note__: you can use the `lms-metadata` tool to have an idea of the tags parsed by _LMS_ using [TagLib](https://github.com/taglib/taglib).
 

approot/admin-database.xml

@@ -34,17 +34,15 @@
 			</div>
 		</div>
 		<legend>${tr:Lms.Admin.Database.scan-options}</legend>
-		${<if-has-recommendation-engine>}
-		<div class="col-lg-6">
-			<label class="form-label" for="${id:recommendation-engine-type}">
-				${tr:Lms.Admin.Database.recommendation-engine-type}
+		<div class="col-12">
+			<label class="form-label" for="${id:similarity-engine-type}">
+				${tr:Lms.Admin.Database.similarity-engine-type}
 			</label>
-			${recommendation-engine-type class="form-control"}
+			${similarity-engine-type class="form-control"}
 			<div class="invalid-feedback">
-				${recommendation-engine-type-info}
+				${similarity-engine-type-info}
 			</div>
 		</div>
-		${</if-has-recommendation-engine>}
 		<div class="col-12">
 			<label class="form-label" for="${id:clusters}">
 				${tr:Lms.clusters}

approot/messages.xml

@@ -53,13 +53,13 @@
 <message id="Lms.Admin.Database.never">Never</message>
 <message id="Lms.Admin.Database.path">Media root directory</message>
 <message id="Lms.Admin.Database.path-help">Directories containing a <code>.lmsignore</code> file are skipped</message>
-<message id="Lms.Admin.Database.recommendation-engine-type">Recommendation engine</message>
-<message id="Lms.Admin.Database.recommendation-engine-type.clusters">Tags based</message>
-<message id="Lms.Admin.Database.recommendation-engine-type.features">Audio analysis based</message>
 <message id="Lms.Admin.Database.scan-complete">Scan complete: {1} total files, {2} additions, {3} updates, {4} deletions, {5} duplicates, {6} errors</message>
 <message id="Lms.Admin.Database.scan-launched">Scan launched!</message>
 <message id="Lms.Admin.Database.scan-options">Scan options</message>
 <message id="Lms.Admin.Database.settings-saved">New settings saved!</message>
+<message id="Lms.Admin.Database.similarity-engine-type">Similarity engine</message>
+<message id="Lms.Admin.Database.similarity-engine-type.clusters">Tag-based</message>
+<message id="Lms.Admin.Database.similarity-engine-type.none">None</message>
 <message id="Lms.Admin.Database.update-period">Update period</message>
 <message id="Lms.Admin.Database.update-start-time">Update start time</message>
 <message id="Lms.Admin.Database.weekly">Weekly</message>
@@ -240,10 +240,14 @@
 <!--Settings-->
 <message id="Lms.Settings.audio">Audio</message>
 <message id="Lms.Settings.audio-settings-are-local">These audio settings are local to your browser!</message>
+<message id="Lms.Settings.backend.internal">Internal</message>
+<message id="Lms.Settings.backend.listenbrainz">ListenBrainz</message>
+<message id="Lms.Settings.backend.listenbrainz-token">ListenBrainz API token</message>
 <message id="Lms.Settings.change-password">Change password</message>
 <message id="Lms.Settings.default-transcode-bitrate">Default transcode bitrate</message>
 <message id="Lms.Settings.default-transcode-format">Default transcode format</message>
 <message id="Lms.Settings.demo-cannot-save">Cannot save using a demo account!</message>
+<message id="Lms.Settings.feedback">Feedback</message>
 <message id="Lms.Settings.menu-settings"><i class="fa fa-fw fa-cog" aria-hidden="true"></i> Settings</message>
 <message id="Lms.Settings.password-bad">Bad password</message>
 <message id="Lms.Settings.password-must-fill-old-password">Old password must be filled in</message>
@@ -255,10 +259,7 @@
 <message id="Lms.Settings.replaygain-preamp">ReplayGain preamp</message>
 <message id="Lms.Settings.replaygain-preamp-no-rg-info">ReplayGain preamp (if no info)</message>
 <message id="Lms.Settings.scrobbling">Scrobbling</message>
-<message id="Lms.Settings.scrobbling.scrobbler">Scrobbler</message>
-<message id="Lms.Settings.scrobbling.scrobbler.internal">Internal</message>
-<message id="Lms.Settings.scrobbling.scrobbler.listenbrainz">ListenBrainz</message>
-<message id="Lms.Settings.scrobbling.listenbrainz-token">ListenBrainz token</message>
+<message id="Lms.Settings.services">Services</message>
 <message id="Lms.Settings.settings">Settings</message>
 <message id="Lms.Settings.subsonic-artist-list-mode">Artist list mode</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.all-artists">All artists</message>

approot/messages_fr.xml

@@ -53,13 +53,13 @@
 <message id="Lms.Admin.Database.never">Jamais</message>
 <message id="Lms.Admin.Database.path">Dossier racine des fichiers de musique</message>
 <message id="Lms.Admin.Database.path-help">Les dossiers contenant un fichier <code>.lmsignore</code> sont ignorés</message>
-<message id="Lms.Admin.Database.recommendation-engine-type">Moteur de recommandation</message>
-<message id="Lms.Admin.Database.recommendation-engine-type.clusters">Basé sur les tags</message>
-<message id="Lms.Admin.Database.recommendation-engine-type.features">Basé sur l'analyse audio</message>
 <message id="Lms.Admin.Database.scan-complete">Scan terminé : {1} fichiers, {2} ajouts, {3} mises à jour, {4} suppressions, {5} duplicatas, {6} erreurs</message>
 <message id="Lms.Admin.Database.scan-launched">Scan lancé !</message>
 <message id="Lms.Admin.Database.scan-options">Options </message>
 <message id="Lms.Admin.Database.settings-saved">Nouveaux paramètres sauvegardés !</message>
+<message id="Lms.Admin.Database.similarity-engine-type">Moteur de similarité</message>
+<message id="Lms.Admin.Database.similarity-engine-type.clusters">Basé sur les tags</message>
+<message id="Lms.Admin.Database.similarity-engine-type.none">Aucun</message>
 <message id="Lms.Admin.Database.update-period">Périodicité des mises à jour</message>
 <message id="Lms.Admin.Database.update-start-time">Heure de départ de la mise à jour</message>
 <message id="Lms.Admin.Database.weekly">Toutes les semaines</message>
@@ -240,10 +240,14 @@
 <!--Settings-->
 <message id="Lms.Settings.audio">Audio</message>
 <message id="Lms.Settings.audio-settings-are-local">Ces paramètres audio sont locaux à votre navigateur !</message>
+<message id="Lms.Settings.backend.internal">Interne</message>
+<message id="Lms.Settings.backend.listenbrainz">ListenBrainz</message>
+<message id="Lms.Settings.backend.listenbrainz-token">Jeton d'API ListenBrainz</message>
 <message id="Lms.Settings.change-password">Changement de mot de passe</message>
 <message id="Lms.Settings.default-transcode-bitrate">Bitrate par defaut du transcodage</message>
 <message id="Lms.Settings.default-transcode-format">Format par defaut du transcodage</message>
 <message id="Lms.Settings.demo-cannot-save">Impossible de sauvegarder en utilisant un compte de démo !</message>
+<message id="Lms.Settings.feedback">Feedback</message>
 <message id="Lms.Settings.menu-settings"><i class="fa fa-fw fa-cog" aria-hidden="true"></i> Paramètres</message>
 <message id="Lms.Settings.password-bad">Mauvais mot de passe</message>
 <message id="Lms.Settings.password-must-fill-old-password">L'ancien mot de passe doit être renseigné</message>
@@ -255,10 +259,7 @@
 <message id="Lms.Settings.replaygain-preamp">Pre-amplification ReplayGain</message>
 <message id="Lms.Settings.replaygain-preamp-no-rg-info">Pre-amplification ReplayGain (si pas d'info)</message>
 <message id="Lms.Settings.scrobbling">Scrobbling</message>
-<message id="Lms.Settings.scrobbling.scrobbler">Scrobbler</message>
-<message id="Lms.Settings.scrobbling.scrobbler.internal">Interne</message>
-<message id="Lms.Settings.scrobbling.scrobbler.listenbrainz">ListenBrainz</message>
-<message id="Lms.Settings.scrobbling.listenbrainz-token">Jeton ListenBrainz</message>
+<message id="Lms.Settings.services">Services</message>
 <message id="Lms.Settings.settings">Paramètres</message>
 <message id="Lms.Settings.subsonic-artist-list-mode">Mode de listage des artistes</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.all-artists">Tous les artistes</message>

approot/messages_it.xml

@@ -9,7 +9,7 @@
 <message id="Lms.cancel">Annulla</message>
 <message id="Lms.clusters">Tags</message>
 <message id="Lms.create">Crea</message>
-<message id="Lms.del">Elimina</message>
+<message id="Lms.delete">Elimina</message>
 <message id="Lms.discard">Annulla</message>
 <message id="Lms.edit">Modifica</message>
 <message id="Lms.loading">Caricamento...</message>
@@ -53,13 +53,13 @@
 <message id="Lms.Admin.Database.never">Mai</message>
 <message id="Lms.Admin.Database.path">Cartella dei file multimediali</message>
 
-<message id="Lms.Admin.Database.recommendation-engine-type">Modalità di raccomandazione brani consigliati</message>
-<message id="Lms.Admin.Database.recommendation-engine-type.clusters">Basata sui tag</message>
-<message id="Lms.Admin.Database.recommendation-engine-type.features">Basata sull'analisi acustica</message>
 <message id="Lms.Admin.Database.scan-complete">Scansione completata: {1} file totali, {2} aggiunti, {3} aggiornati, {4} eliminati, {5} duplicati, {6} errati</message>
 <message id="Lms.Admin.Database.scan-launched">Scansione avviata!</message>
 <message id="Lms.Admin.Database.scan-options">Impostazioni scansione</message>
 <message id="Lms.Admin.Database.settings-saved">Impostazioni salvate!</message>
+
+
+
 <message id="Lms.Admin.Database.update-period">Frequenza di aggiornamento</message>
 <message id="Lms.Admin.Database.update-start-time">Orario di aggiornamento</message>
 <message id="Lms.Admin.Database.weekly">Settimanale</message>
@@ -240,10 +240,14 @@
 <!--Settings-->
 <message id="Lms.Settings.audio">Audio</message>
 <message id="Lms.Settings.audio-settings-are-local">Queste impostazioni sono salvate localmente su questo dispositivo!</message>
+
+
+
 <message id="Lms.Settings.change-password">Cambia password</message>
 
 
 <message id="Lms.Settings.demo-cannot-save">Non posso salvare le impostazioni utilizzando l'account demo!</message>
+
 <message id="Lms.Settings.menu-settings"><i class="fa fa-fw fa-cog" aria-hidden="true"></i> Impostazioni</message>
 <message id="Lms.Settings.password-bad">Password errata</message>
 <message id="Lms.Settings.password-must-fill-old-password">Devi inserire la password attuale</message>
@@ -257,9 +261,6 @@
 
 
 
-
-
-
 <message id="Lms.Settings.subsonic-artist-list-mode">Modalità di elencazione artisti</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.all-artists">Tutti gli artisti</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.release-artists">Artisti album</message>

approot/messages_zh.xml

@@ -53,13 +53,13 @@
 <message id="Lms.Admin.Database.never">从不</message>
 <message id="Lms.Admin.Database.path">媒体根目录</message>
 <message id="Lms.Admin.Database.path-help">包含 <code>.lmsignore</code> 文件的目录将会被跳过</message>
-<message id="Lms.Admin.Database.recommendation-engine-type">推荐引擎</message>
-<message id="Lms.Admin.Database.recommendation-engine-type.clusters">基于标签</message>
-<message id="Lms.Admin.Database.recommendation-engine-type.features">基于音频分析</message>
 <message id="Lms.Admin.Database.scan-complete">扫描完成：总文件 {1}，添加文件 {2}，更新文件 {3}，删除文件 {4}，重复文件 {5}，错误文件 {6}</message>
 <message id="Lms.Admin.Database.scan-launched">扫描已完成！</message>
 <message id="Lms.Admin.Database.scan-options">扫描选项</message>
 <message id="Lms.Admin.Database.settings-saved">新设置已保存！</message>
+
+
+
 <message id="Lms.Admin.Database.update-period">更新周期</message>
 <message id="Lms.Admin.Database.update-start-time">更新开始时间</message>
 <message id="Lms.Admin.Database.weekly">每周</message>
@@ -240,10 +240,14 @@
 <!--Settings-->
 <message id="Lms.Settings.audio">音频</message>
 <message id="Lms.Settings.audio-settings-are-local">这些音频设置仅保存在您的本地浏览器！</message>
+
+
+
 <message id="Lms.Settings.change-password">更改密码</message>
 
 
 <message id="Lms.Settings.demo-cannot-save">使用演示账号时不能保存！</message>
+
 <message id="Lms.Settings.menu-settings"><i class="fa fa-fw fa-cog" aria-hidden="true"></i> 设置</message>
 <message id="Lms.Settings.password-bad">无效密码</message>
 <message id="Lms.Settings.password-must-fill-old-password">必须填写旧密码</message>
@@ -257,9 +261,6 @@
 
 
 
-
-
-
 <message id="Lms.Settings.subsonic-artist-list-mode">歌手列表模式</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.all-artists">所有歌手</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.release-artists">专辑歌手</message>

approot/search.xml

@@ -3,29 +3,29 @@
 <!--FORMS message blocks-->
 
 <message id="Lms.Explore.Search.template">
-	<ul class="nav nav-pills mb-3" id="myTab" role="tablist">
-		<li class="nav-item" role="presentation">
-			<button class="nav-link active" id="releases-tab" data-bs-toggle="tab" data-bs-target="#releases" type="button" role="tab" aria-controls="releases" aria-selected="true">${tr:Lms.Explore.releases}</button>
-		</li>
-		<li class="nav-item" role="presentation">
-			<button class="nav-link" id="artists-tab" data-bs-toggle="tab" data-bs-target="#artists" type="button" role="tab" aria-controls="artists" aria-selected="false">${tr:Lms.Explore.artists}</button>
-		</li>
-		<li class="nav-item" role="presentation">
-			<button class="nav-link" id="tracks-tab" data-bs-toggle="tab" data-bs-target="#tracks" type="button" role="tab" aria-controls="tracks" aria-selected="false">${tr:Lms.Explore.tracks}</button>
-		</li>
-	</ul>
-	<div class="tab-content" id="myTabContent">
-		<div class="tab-pane show active" id="releases" role="tabpanel" aria-labelledby="releases-tab">${releases}</div>
-		<div class="tab-pane" id="artists" role="tabpanel" aria-labelledby="artists-tab">
-			<div class="row mb-3">
-				<div class="col-lg-3">
-					${link-type class="form-select"}
-				</div>
-			</div>
-			${artists}
+	<div class="mb-3">
+		<ul class="nav nav-pills mb-3">
+			<li class="nav-item">
+				${releases class="nav-link"}
+			</li>
+			<li class="nav-item">
+				${artists class="nav-link"}
+			</li>
+			<li class="nav-item">
+				${tracks class="nav-link"}
+			</li>
+		</ul>
+	</div>
+	${results}
+</message>
+
+<message id="Lms.Explore.Search.template.artists">
+	<div class="row mb-3">
+		<div class="col-lg-3">
+			${link-type class="form-select"}
 		</div>
-		<div class="tab-pane" id="tracks" role="tabpanel" aria-labelledby="tracks-tab">${tracks}</div>
 	</div>
+	${artists}
 </message>
 
 </messages>

approot/settings.xml

@@ -28,9 +28,9 @@
 			</div>
 		</div>
 		<div class="col-lg-4">
-			<label class="form-label"  for="${id:transcode-bitrate}">
+			<label class="form-label" for="${id:transcode-bitrate}">
 				${tr:Lms.Settings.transcode-bitrate}
-;			</label>
+			</label>
 			<div class="input-group mb-3">
 				${transcode-bitrate class="form-control"}
 				<span class="input-group-text">kbps</span>
@@ -105,19 +105,28 @@
 				</div>
 			</div>
 			${</if-has-subsonic-api>}
-		<legend>${tr:Lms.Settings.scrobbling}</legend>
+		<legend>${tr:Lms.Settings.services}</legend>
 		<div class="col-lg-6">
-			<label class="form-label" for="${id:scrobbler}">
-				${tr:Lms.Settings.scrobbling.scrobbler}
+			<label class="form-label" for="${id:scrobbling-backend}">
+				${tr:Lms.Settings.scrobbling}
 			</label>
-			${scrobbler class="form-control"}
+			${scrobbling-backend class="form-control"}
 			<div class="invalid-feedback">
-				${scrobbler-info class="help-block"}
+				${scrobbling-backend-info class="help-block"}
 			</div>
 		</div>
 		<div class="col-lg-6">
+			<label class="form-label" for="${id:feedback-backend}">
+				${tr:Lms.Settings.feedback}
+			</label>
+			${feedback-backend class="form-control"}
+			<div class="invalid-feedback">
+				${feedback-backend-info class="help-block"}
+			</div>
+		</div>
+		<div class="col-lg-12">
 			<label class="form-label" for="${id:listenbrainz-token}">
-				${tr:Lms.Settings.scrobbling.listenbrainz-token}
+				${tr:Lms.Settings.backend.listenbrainz-token}
 			</label>
 			${listenbrainz-token class="form-control"}
 			<div class="invalid-feedback">

conf/lms.conf

@@ -63,6 +63,9 @@ api-subsonic = true;
 # Main usage is to make auto detections for the 'p' (password) parameter work
 api-subsonic-report-old-server-protocol = ("DSub");
 
+# List of clients for whom open subsonic extensions and extra fields are disabled
+api-open-subsonic-disabled-clients = ("DSub");
+
 # Turn on this option to allow the demo account creation/use
 demo = false;
 
@@ -85,4 +88,4 @@ playqueue-max-entry-count = 1000;
 scanner-skip-duplicate-mbid = false;
 
 # Scanner read style for metadata, maybe be 'fast', 'average' or 'accurate'
-scanner-parser-read-style = "accurate";
+scanner-parser-read-style = "average";

src/libs/av/impl/TranscodeResourceHandler.cpp

@@ -56,10 +56,12 @@ namespace Av
 		if (_estimatedContentLength)
 			response.setContentLength(*_estimatedContentLength);
 		response.setMimeType(_transcoder.getOutputMimeType());
-		LMS_LOG(TRANSCODE, DEBUG) << "Set mime type to " << _transcoder.getOutputMimeType();
+		LMS_LOG(TRANSCODE, DEBUG) << "Transcoder finished = " << _transcoder.finished() << ", total served bytes = " << _totalServedByteCount << ", mime type = " << _transcoder.getOutputMimeType();
 
 		if (_bytesReadyCount > 0)
 		{
+			LMS_LOG(TRANSCODE, DEBUG) << "Writing " << _bytesReadyCount << " bytes back to client";
+
 			response.out().write(reinterpret_cast<const char *>(&_buffer[0]), _bytesReadyCount);
 			_totalServedByteCount += _bytesReadyCount;
 			_bytesReadyCount = 0;
@@ -71,6 +73,8 @@ namespace Av
 			continuation->waitForMoreData();
 			_transcoder.asyncRead(_buffer.data(), _buffer.size(), [=](std::size_t nbBytesRead)
 			{
+				LMS_LOG(TRANSCODE, DEBUG) << "Have " << nbBytesRead << " more bytes to send back";
+
 				assert(_bytesReadyCount == 0);
 				_bytesReadyCount = nbBytesRead;
 				continuation->haveMoreData();

src/libs/services/CMakeLists.txt

@@ -1,6 +1,7 @@
 add_subdirectory(auth)
 add_subdirectory(cover)
 add_subdirectory(database)
+add_subdirectory(feedback)
 add_subdirectory(recommendation)
 add_subdirectory(scanner)
 add_subdirectory(scrobbling)