[Fix] Add margin #92
Merged
[Fix] Add margin #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrizzle
force-pushed
the
britz-add-margin
branch
2 times, most recently
from
a38072b
to
312b5e3
Compare
kbrizzle
force-pushed
the
britz-add-margin
branch
from
312b5e3
to
89efc21
Compare
[Payoff] Unit Test Code Coverage ReportCoverage after merging britz-add-margin into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Payoff] Integration Test Code Coverage ReportCoverage after merging britz-add-margin into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Extensions] Unit Test Coverage ReportCoverage after merging britz-add-margin into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||
[Oracle] Unit Test Coverage ReportCoverage after merging britz-add-margin into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Core] Integration Test Coverage ReportCoverage after merging britz-add-margin into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Extensions] Integration Test Coverage ReportCoverage after merging britz-add-margin into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||
[Vault] Integration Test Coverage ReportCoverage after merging britz-add-margin into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Core] Unit Test Coverage ReportCoverage after merging britz-add-margin into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Oracle] Integration Test Coverage ReportCoverage after merging britz-add-margin into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
arjun-io
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core
margin/minMarginrisk parameters that apply to the current pending position, while movingmaintenance/minMaintenanceto only apply to the non-current pending and latest positions.Vault
margininstead ofmaintenancefor all minimum collateral checks (since positions are frequently updated, margin is a more accurate lower bound)minMargincorresponding to the buffer betweenleverageandmaintenance, whereas before it would useminMargindirectly leading to situations where it could be near a liquidation.Fixes: sherlock-audit/2023-07-perennial-judging#104.
(applicable to many reported issues)