feat: Add support for executing custom user data #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthaha
reviewed
Sep 18, 2024
sthaha
reviewed
Sep 18, 2024
action.yml
Outdated
| echo "Running custom user data" | ||
| echo "${{ inputs.custom_user_data }}" | tee /tmp/custom_user_data.sh | ||
| chmod +x /tmp/custom_user_data.sh | ||
| sudo /tmp/custom_user_data.sh |
There was a problem hiding this comment.
sudo changes user to root is that intentional?
E.g. if I want to run pip install --user foobar it will be installed in /root instead of current user.
There was a problem hiding this comment.
@sthaha @vprashar2929 userdata/cloud-init is run as the root user. sudo can be removed.
vprashar2929
force-pushed
the
custom-u-data
branch
from
9cdbb30 to
24b29c9
Compare
sthaha
reviewed
Sep 18, 2024
vprashar2929
force-pushed
the
custom-u-data
branch
from
24b29c9 to
e447d69
Compare
displague
reviewed
Sep 26, 2024
This commit introduces the ability to run a custom script prior to installing and starting the runner service. Users can now pass custom script (runs as sudo) to configure their runners with specific requirements before the runner is fully initialized. A new input parameter `custom_script` has been added. It accepts a string value representing the custom script. If this parameter is provided, the script will be executed before the runner service starts, allowing for custom configurations or setup tasks to be performed seamlessly. Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com>
vprashar2929
force-pushed
the
custom-u-data
branch
from
e447d69 to
49df56d
Compare
displague
approved these changes
Sep 27, 2024
|
@vprashar2929 Thanks for the quick turn-around. Could you also update the README.md Inputs and example with the new parameter |
displague
requested changes
Sep 27, 2024
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the ability to run a custom script prior to installing and starting the runner service. Users can now pass custom script (runs as sudo) to configure their runners with specific requirements before the runner is fully initialized.
A new input parameter
custom_scripthas been added. It accepts a string value representing the custom script. If this parameter is provided, the script will be executed before the runner service starts, allowing for custom configurations or setup tasks to be performed seamlessly.Address: #13