fix: prevent script from being executed during conditional checks #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vprashar2929
force-pushed
the
fix-custom-scr
branch
from
57d9e60
to
0f9838d
Compare
|
cc: @displague |
|
I didn't see #16 I will revert the docs changes from this PR |
This commit addresses an issue where the custom script could inadvertently be executed as part of a conditional check, leading to unintended behavior. Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com>
vprashar2929
force-pushed
the
fix-custom-scr
branch
from
0f9838d
to
9f3f18c
Compare
cprivitere
reviewed
Oct 2, 2024
| chmod 0700 $CUSTOM_SCRIPT | ||
| echo "Running custom user script" | ||
| $CUSTOM_SCRIPT | ||
| ./$CUSTOM_SCRIPT |
There was a problem hiding this comment.
When I try this on my machine, I get output like this:
./$CUSTOM_SCRIPT
bash: .//home/cprivitere/custom_script.rzk23.sh: No such file or directory
Shouldn't it be $CUSTOM_SCRIPT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue where the custom script could inadvertently be executed as part of a conditional check, leading to unintended behavior.