make exec arg handling precise (#191) #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required fixing the tests which quoted "echo hello world" as one argv, which never should have worked, but did because of sh -c. This changes behavior in otel-cli to be more picky about how args are passed in. It might break some folks who are expecting sh -c behavior? Gonna post the diffs/PR and have a discussion in #191.
tobert
commented
May 10, 2023
| @@ -638,7 +639,7 @@ var suites = []FixtureSuite{ | |||
| Config: FixtureConfig{ | |||
| CliArgs: []string{ | |||
| "exec", "--name", "outer", "--endpoint", "{{endpoint}}", "--fail", "--verbose", "--", | |||
| "./otel-cli", "exec", "--name", "inner", "--endpoint", "{{endpoint}}", "--tp-required", "--fail", "--verbose", "echo hello world"}, | |||
| "./otel-cli", "exec", "--name", "inner", "--endpoint", "{{endpoint}}", "--tp-required", "--fail", "--verbose", "echo", "hello world"}, | |||
There was a problem hiding this comment.
I hate changing the tests here but "echo hello world" was a horrible choice I made, and don't remember why.
Closed
shastah
added a commit
to shastah/otel-cli
that referenced
this pull request
Aug 12, 2024
This example from README: ``` # otel-cli propagates context via envvars so you can chain it to create child spans otel-cli exec --kind producer "otel-cli exec --kind consumer sleep 1" ``` doesn't work, because we're running into equinix-labs#356. It worked until `/bin/sh -c` was removed in equinix-labs#202.
shastah
added a commit
to shastah/otel-cli
that referenced
this pull request
Aug 12, 2024
This example from README:
# otel-cli propagates context via envvars so you can chain it to create child spans
otel-cli exec --kind producer "otel-cli exec --kind consumer sleep 1"
doesn't work, because we're running into equinix-labs#356.
It worked until `/bin/sh -c` was removed in equinix-labs#202.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required fixing the tests which quoted "echo hello world" as one argv, which never should have worked, but did because of sh -c.
This changes behavior in otel-cli to be more picky about how args are passed in. It might break some folks who are expecting sh -c behavior?
Gonna post the diffs/PR and have a discussion in #191.