fix endpoint paths and signal-specific behavior (#200) #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 23, 2023 13:36
Modified checkProcess to return a bool if the process met the expected conditions. If it failed unexpectedly, checkAll will bail out of running further checks on the data, so output is a lot less spammy. Added "*" support to the check on diagnostics data strings.
Adds 2 tests to the regression suite to validate endpoints on general get /v1/traces appended, and that signal endpoints do not.
Moved URL parsing to its own func, moving some code from the http/grpc option paths to it, as well as starting to consider the "source" of general (e.g. --endpoint, OTEL_EXPORTER_OTLP_ENDPOINT) or a signal (e.g. --signal-endpoint or OTEL_EXPORTER_OTLP_TRACES_ENDPOINT). They are treated differently now to match the spec. Added tests for parseEndpoint.
e.g. "localhost", "127.0.0.1" are always going to go to gRPC, and when no port is provided, should default to 4317. Might need to check the spec. It probably doesn't allow for bare hostname but otel-cli will because it should be easy to type.
This was referenced May 25, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks endpoint handling to closer match the OTel spec and solve problems noticed in #200.