Remove std cutoff filtering in HISTORY_OBSERVATION #8498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindeide
added
the
release-notes:improvement
oyvindeide
force-pushed
the
remove_std_cutoff
branch
2 times, most recently
from
0dad1ac to
01898dc
Compare
Not sure this was intended, as this property is meant to filter out ensembles based on the ensemble std, i.e. from the responses. Additionally HISTORY_OBSERVATION is not really recommended, and by filtering out earlier scaling factors are not applied, which could impact the outcome.
oyvindeide
force-pushed
the
remove_std_cutoff
branch
from
01898dc to
2cdfecd
Compare
sondreso
approved these changes
Aug 16, 2024
oyvindeide
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8498 +/- ##
==========================================
- Coverage 90.65% 90.63% -0.02%
==========================================
Files 344 344
Lines 20969 20965 -4
==========================================
- Hits 19009 19002 -7
- Misses 1960 1963 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #8353
When applicable