Have ErtStorageExceptions not be unexpected in cli #9407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-eq
added
the
release-notes:bug-fix
|
What about a test? |
jonathan-eq
force-pushed
the
fix-storag
branch
from
373d5e1 to
bacbf99
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9407 +/- ##
==========================================
+ Coverage 91.83% 91.90% +0.07%
==========================================
Files 434 434
Lines 26735 26736 +1
==========================================
+ Hits 24551 24571 +20
+ Misses 2184 2165 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xjules
reviewed
Dec 6, 2024
|
|
||
| except PermissionError as error: | ||
| logger.exception((f"Unexpected exception in ensemble: \n {error!s}")) | ||
| await event_unary_send(event_creator(Id.ENSEMBLE_FAILED)) |
There was a problem hiding this comment.
Now when this gets propagated I'd expect that you will check such status in the test.(?)
There was a problem hiding this comment.
This was leftovers from 90c14a9 that was included due to some git wizardry 🧙♂️.
I will add some tests for it in a different PR 🌴 🌞
This commit: * Improves the error message displayed when the dark storage server does not have access to the storage path. * Makes the dark storage server return a response with status code 401 - unauthorized when the `get_ensemble_record` endpoint fails due to `PermissionError`. * Makes the failed message in `LegacyEnsemble._evaluate_inner` omit stacktrace when it failed due to PermissionError, making it shorter and more consise.
jonathan-eq
force-pushed
the
fix-storag
branch
from
bacbf99 to
1b75f60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits makes ErtStorageExceptions not be output as "unexpected error" in cli.
Issue
Resolves #9223
Approach
This PR improves the way ErtStorageExceptions are handled and displayed in the cli. Prior to this PR, ErtStorageExceptions were "unexpected" in the cli.
How it was before this change:
(Screenshot of new behavior in GUI if applicable)
This is now more similar to how it is output in the gui:
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable