Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement robot specific stop button #1799

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

haakonsf
Copy link
Contributor

@haakonsf haakonsf commented Nov 19, 2024

Closes #1779

@haakonsf haakonsf force-pushed the add-stop-button-to-robot-cards branch from 52cf4fc to c59c02a Compare November 20, 2024 09:40
@haakonsf haakonsf marked this pull request as ready for review November 20, 2024 09:46
@haakonsf haakonsf changed the title Implement functionality for unconditional stop Implement robot specific stop button Nov 20, 2024
@haakonsf
Copy link
Contributor Author

Dependent on equinor/isar#634

@haakonsf haakonsf force-pushed the add-stop-button-to-robot-cards branch from c59c02a to 5bddb70 Compare November 20, 2024 13:23
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haakonsf haakonsf force-pushed the add-stop-button-to-robot-cards branch from 4589011 to 692a987 Compare November 25, 2024 15:19
@haakonsf
Copy link
Contributor Author

PR needs an update to work with the new frontend design issue #1822 is related and can be done at the same time

@haakonsf haakonsf force-pushed the add-stop-button-to-robot-cards branch 2 times, most recently from 17de8b2 to 7f02b0c Compare November 29, 2024 12:59
@haakonsf haakonsf force-pushed the add-stop-button-to-robot-cards branch from 7f02b0c to e819a60 Compare November 29, 2024 13:31
@haakonsf haakonsf merged commit 4d96716 into equinor:main Nov 29, 2024
11 checks passed
@haakonsf haakonsf deleted the add-stop-button-to-robot-cards branch November 29, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add stop button on robot cards
2 participants