Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow stopping missions from idle state #634

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Allow stopping missions from idle state #634

merged 1 commit into from
Nov 29, 2024

Conversation

haakonsf
Copy link
Contributor

No description provided.

@haakonsf haakonsf marked this pull request as draft October 24, 2024 14:29
@haakonsf haakonsf force-pushed the allow-stopping-from-idle branch from 89a1d09 to 7bf2151 Compare October 29, 2024 09:30
@haakonsf haakonsf marked this pull request as ready for review October 29, 2024 09:48
andchiind
andchiind approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but might want to label this change a breaking change, as it will affect ISAR implementations. We need to make sure they do not crash if they receive the "stop" function call when they don't have a mission running.

src/isar/apis/schedule/scheduling_controller.py Outdated Show resolved Hide resolved
@haakonsf haakonsf mentioned this pull request Oct 29, 2024
Closed
@haakonsf
Copy link
Contributor Author

Postponing merging this until isar-taurob test

@haakonsf haakonsf mentioned this pull request Nov 20, 2024
Merged
@haakonsf haakonsf force-pushed the allow-stopping-from-idle branch from 7bf2151 to 7ddfe35 Compare November 20, 2024 13:05
@haakonsf haakonsf merged commit ce0e4e4 into equinor:main Nov 29, 2024
6 checks passed
@haakonsf haakonsf deleted the allow-stopping-from-idle branch November 29, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haakonsf @andchiind