Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Well Log Viewer Module #702

Closed
wants to merge 73 commits into from
Closed

Implement Well Log Viewer Module #702

wants to merge 73 commits into from

Conversation

Anders2303
Copy link
Collaborator

@Anders2303 Anders2303 commented Aug 22, 2024

Resolves issue #683

Adds a wrapper module for the Subsurface WellLogViewer.

TODOs

This uses the readout box and sortable list components introduced in other PRs, those should be reviewed and merged first

Specifications (1st iteration):

  • Settings
    • Dropdown for selecting ensemble
    • Load available wellbores for field given by selected ensemble from backend
    • Dropdown for selecting wellbore
    • Definition of logs (columns) - Intersection module with its layer manager could give some inspiration
  • View
    • Use well-log-viewer component to visualize well log defined in settings
    • Load data required for visualization from backend
  • Define interface for sending log definitions, ensemble, and wellbore from settings to view

Specifications (2nd iteration):

  • Setting sync
    • Ensemble
      • Skipped this one, we dont have any existing setup for synced field
    • Wellbore
  • View
  • Colors
    • Avoid random colors each re-render
    • Make colors update when workbench color settings are changed
    • User color selection

Specifications (3rd iteration):

  • Extra curve types
    • Diff curves.
    • Discrete curves. The viewer supports it, but requires a "discrete_metadata" field for the well-log. How do we fetch or set up these?
  • Settings
    • Map out other settings in the subsurface component, and see what makes sense to expose for our users
      • Horizontal/vertical orientation
      • Curve-specific scales
    • Make definitions of log storable in and selectable from local storage (maybe in addition or alternatively savable as/loadable from JSON file)

Specifications (4th iteration):

  • Evaluate if component created by Aspentech is sufficient - maybe it requires refactoring to fit into our application (e.g. remove legend and primary scale and make it possible to define these on the outside via props/callbacks)

rubenthoms and others added 30 commits August 12, 2024 15:22
@Anders2303 Anders2303 marked this pull request as ready for review September 10, 2024 08:37
@Anders2303 Anders2303 added the enhancement New feature or request label Sep 10, 2024
@Anders2303
Copy link
Collaborator Author

The branch commit history got messed up due to some erroneous rebases. Timestamps got messed up, and it might have introduced some unrelated changes as "new".

Closing this, and recreating the branch and PR in #794

@Anders2303 Anders2303 closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants