Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Intersection and 3D viewer readout boxes with shared comp #707

Merged
merged 19 commits into from
Sep 24, 2024
Merged

Replace Intersection and 3D viewer readout boxes with shared comp #707

merged 19 commits into from
Sep 24, 2024

Conversation

Anders2303
Copy link
Collaborator

  • Moved the EsvIntersection and VectorSelect components from framework/components to modules/_shared
  • Replaced the ReadoutBox components in EsvIntersection and 3dViewer with a shared ReadoutBoxc component
    • Also added logic to have the readout-box move away from the mouse by flipping it's position.

@Anders2303 Anders2303 marked this pull request as ready for review August 30, 2024 08:07
This was referenced Aug 30, 2024
Closed
Open
rubenthoms
rubenthoms requested changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@rubenthoms rubenthoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me 👍 Some comments and suggestions. When used in Intersection, it would be nice to be able to adjust the distance to the respective edges in order to not having the color scale being overlapped.

frontend/src/modules/_shared/components/ReadoutBox.tsx Show resolved Hide resolved
frontend/src/modules/_shared/components/ReadoutBox.tsx Outdated Show resolved Hide resolved
frontend/src/modules/_shared/components/ReadoutBox.tsx Outdated Show resolved Hide resolved
frontend/src/modules/_shared/components/ReadoutBox.tsx Outdated Show resolved Hide resolved
frontend/src/modules/_shared/components/ReadoutBox.tsx Outdated Show resolved Hide resolved
frontend/src/modules/_shared/components/ReadoutBox.tsx Outdated Show resolved Hide resolved
frontend/src/modules/_shared/components/ReadoutBox.tsx Outdated Show resolved Hide resolved
frontend/src/modules/Intersection/view/components/readoutWrapper.tsx Outdated Show resolved Hide resolved
frontend/src/modules/Intersection/view/components/readoutWrapper.tsx Outdated Show resolved Hide resolved
frontend/src/modules/_shared/components/ReadoutBox.tsx Outdated Show resolved Hide resolved
rubenthoms
rubenthoms approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@rubenthoms rubenthoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions, otherwise, good to go 👍 Good job!

frontend/src/lib/hooks/useStableProp.ts Outdated Show resolved Hide resolved
frontend/src/modules/3DViewer/view/components/ReadoutBoxWrapper.tsx Outdated Show resolved Hide resolved
frontend/src/modules/Intersection/view/components/readoutWrapper.tsx Outdated Show resolved Hide resolved
@Anders2303 Anders2303 merged commit dad0eec into main Sep 24, 2024
11 checks passed
@Anders2303 Anders2303 mentioned this pull request Nov 4, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenthoms rubenthoms rubenthoms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anders2303 @rubenthoms @lindjoha