Expose a ClearScreen method #37
Conversation
For parity with the original library; fixes #36
| @@ -304,6 +302,11 @@ func (i *Instance) EnableHistory() { | |||
| i.operation.history.Enable() | |||
| } | |||
|
|
|||
| // ClearScreen clears the screen. | |||
| func (i *Instance) ClearScreen() { | |||
There was a problem hiding this comment.
I'm not very familiar with the internals of this library, but in my experiments I had to call o.Clean() and o.Refresh() as well. Should this be part of the ClearScreen method?
There was a problem hiding this comment.
If you write to (*Instance).Stdout() or similar, it will refresh automatically via wrapWriter:
Line 41 in eb5f59c
| @@ -38,11 +37,6 @@ func GetScreenSize() (width int, height int) { | |||
| return | |||
| } | |||
|
|
|||
| // ClearScreen clears the console screen | |||
| func ClearScreen(_ io.Writer) error { | |||
| return SetConsoleCursorPosition(&_COORD{0, 0}) | |||
| @@ -74,6 +75,11 @@ func (r *rawModeHandler) Exit() error { | |||
| return err | |||
| } | |||
|
|
|||
| func clearScreen(w io.Writer) error { | |||
| _, err := w.Write([]byte("\x1b[H\x1b[J")) | |||
There was a problem hiding this comment.
Maybe at some point named constant etc for ansi stuff could be nice for readability?
There was a problem hiding this comment.
Yeah, maybe. What I've found in the past is that the composition rules are tricky. ircdog used to use mgutz/ansi --- I ended up removing it and handcrafting my own ANSI codes because I found that it obscured more than it clarified.
There was a problem hiding this comment.
Aha i see, yeah i actually ran into something similar when trying to general ANSI-aware line wrapper for fq :)
For parity with the original library; fixes #36.
cc @wader @dominikschulz
We no longer need platform-specific screen-clearing code, as per #2. Some of the other platform-specific utilities may be obsolete as well...
I tested this on Linux and Windows with the readline demo, and on Linux with gopasspw/gopass#2684 using
replacein go.mod. Everything looks OK so far.