Replace chzyer/readline with ergochat/readline #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former seemed unmaintained and was lacking patches required for OpenBSD. See gopasspwGH-2683 Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
|
The REPL is working well for me with this on OpenBSD. |
|
The problem is that the Not sure if we wan't to merge it as is. |
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
use readline 0.0.6's ClearScreen method
AnomalRoil
approved these changes
Nov 8, 2023
|
The code looks good, but I want to quickly tests it before merging. Should be done soon and then we should try to cut a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former seemed unmaintained and was lacking patches required for OpenBSD.
See GH-2683.
Some small changes were necessary since the ergochat fork changed the API a bit.