Candidate for 5.0.15 release #1036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kushti
commented
Nov 27, 2024
•
kushti
commented
- scrypto version updated to 3.0.0 (close Uses library outside Maven central #1030 )
- Finish executeFromVar implementation #976
6.0.0 activation
…nterpreter into v6.0.0
…rpreter into v6.0.0
… deserialize test
…rpreter into i443
Finish executeFromVar implementation
aslesarenko
requested changes
Dec 13, 2024
| * Def done in order to carry on DeserializeContext through stages of compilation intact | ||
| */ | ||
| case class DeserializeContextDef[V <: SType](d: DeserializeContext[V], e: Elem[V]) extends Def[V] { | ||
| override def resultType: Elem[V] = e |
There was a problem hiding this comment.
There is a problem with typing here. In a type like Elem[V], the V should be a type of data value (Int, Long, Boolean, Coll, GroupElement). However, the V <: SType part suggests V to be SInt, SLong, SBoolean, etc.
The compiler is not complaining likely because of .asInstanceOf[] being used.
It should be ..., e: Elem[V#WrappedType]) extends Def[V#WrappedType] ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.