Finish executeFromVar implementation #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6.0.0 activation
…nterpreter into v6.0.0
2 tasks
…rpreter into v6.0.0
… deserialize test
kushti
changed the title
kushti
changed the title
aslesarenko
requested changes
Jul 24, 2024
| * Def done in order to carry on DeserializeContext through stages of compilation intact | ||
| */ | ||
| case class DeserializeContextDef[V <: SType](d: DeserializeContext[V], e: Elem[V]) extends Def[V] { | ||
| override def resultType: Elem[V] = e |
There was a problem hiding this comment.
The connection between SType and Elem[T] is a bit more nuanced.
V <: SType corresponds to Elem[V#WrappedType], in other words, V is a descriptor for V#WrappedType and Elem[T] is a descriptor for T.
There was a problem hiding this comment.
What does that mean ? What do you propose?
There was a problem hiding this comment.
It should be e: Elem[V#WrappedType].
There was a problem hiding this comment.
Isn't the type right for e.g. Coll[Byte]: CollElem<Coll[Byte]> ?
|
@aslesarenko comments addressed, please make another pass |
…rpreter into i443
|
@aslesarenko please check new notes |
aslesarenko
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains complete implementation (with tests) of executeFromVar support in the ErgoScript compiler.
Related to #443, #600