Updates for PR#614 #1
Conversation
ccpp/data/GFS_typedefs.F90
Outdated
| @@ -4174,7 +4174,12 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, master, & | |||
| Model%ivegsrc = ivegsrc | |||
| Model%isot = isot | |||
| Model%use_ufo = use_ufo | |||
| Model%vrbliceden_noah = vrbliceden_noah | |||
| Model%exticeden = exticeden | |||
| if (Model%exticeden .and. (imp_physics /= imp_physics_gfdl .and. imp_physics /= imp_physics_thompson .and. imp_physics /= imp_physics_nssl )) then | |||
There was a problem hiding this comment.
@ericaligo-NOAA I put this check in here because the calculation of rhonewsn in GFS_MP_generic_post is within an IF statement for these 3 MP schemes. If we don't have a check like this, it would be possible to specify exticeden = T in the namelist for a suite using a different microphysics and the LSMs would bypass their internal calculation of frozen precipitation density in favor of a bogus/initialized-only value of rhonewsn.
|
@ericaligo-NOAA By putting in the flag to use the externally-calculated rhonewsn value in RUC LSM (rather than requiring it as your original code had), this changes the original behavior of your PR code unless you add |
|
@ericaligo-NOAA Just a reminder that this needs to be merged too, after ericaligo-NOAA/ccpp-physics#1 was merged since ccpp_prebuild won't work without these changes too. |
|
@grantfirl @ericaligo-NOAA I didn't know you have this PR for Eric until you mentioned in the meeting today. I think Eric had made those changes but didn't merge your changes into his branch. Eric, could you compare your changes with Grant's changes to make sure your changes are right? |
|
Sure. How would I do that?
…On 1/27/2023 1:24 PM, ChunxiZhang-NOAA wrote:
@grantfirl <https://github.com/grantfirl> @ericaligo-NOAA
<https://github.com/ericaligo-NOAA> I didn't know you have this PR for
Eric until you mentioned in the meeting today. I think Eric had made
those changes but didn't merge your changes into his branch. Eric,
could you compare your changes with Grant's changes to make sure your
changes are right?
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MIBL4UABUGJTFWSZZLWUQHHNANCNFSM6AAAAAATYY3E3A>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Just compare your CCPP_typedefs.meta, GFS_typedefs.meta and GFS_typedefs.F90 with Grant's files here to see if they are same or reasonably similar. |
|
If they are same or reasonably similar, you don't need to do anything. |
* In GFS_diagnostics make LAI, WILT and FLDCP be outputted with all LSMs. Also, output of LAI should not depend on RDLAI. * In GFS_typedefs.* add surface heat flux from the fire for use in RUC LSM. * Fix hail size output diagnostic array size (#1) * Added one more variable - frac_grid_burned_out - to GFS_typedefs.F90. Also, the surface heat flux from fires and frac_grid_burned_out are added to the model output in GFS_diagnostics.F90. --------- Co-authored-by: tanyasmirnova <tanya.smirnova@noaa.gov> Co-authored-by: Anders Jensen <anders.jensen@noaa.gov>
Changes:
@ericaligo-NOAA I'm running the RTs on Hera on Wed. evening. So far, compilation has succeeded, which means that my changes will have passed ccpp_prebuild.py and are OK.