Address Windows-shell fuzz crashes #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an item that cause crashes when fuzzing cmd.exe in the repository in the CI at [1]. Based on local testing this also affects PowerShell. -- 1. 6c31238
Update the arg preparation when fuzzing cmd.exe by accounting for newly stripped characters by Shescape when preparing arguments containing forward slashes. In particular in addition to `\0`, Shescape also strips `\u0008`, `\u001B`, and `\u009B`. Accordingly, fix the comment explaining to replacement as it incorrectly claims that `\0` is ignored (while in fact it's Shescape that removes it).
Add an item that cause crashes when fuzzing PowerShell in the repository in the CI at [1]. Based on local testing this does not affect cmd.exe -- 1. 6c31238
Update the arg preparation when fuzzing PowerShell by accounting for newly stripped characters by Shescape when preparing arguments containing forward slashes. In particular in addition to `\0`, Shescape also strips `\u0008`, `\u001B`, and `\u009B`. Accordingly, fix comments explaining the replacements as they incorrectly claim that `\0` is ignored (while in fact it's Shescape that removes it).
Improve how the carriage return character is considered when preparing arguments for PowerShell. In particular, rather than only considering it at the end of the argument, consider it any time it's not followed by a line feed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #463
Summary
This is to address the fuzz crash (
9729c65) found by this nightly CI run - additionally it addresses another fuzz crash (4af9014) found as part of this Pull Request.. Given the nature of these crashes, it is suspected there's something wrong with the fuzz logic rather than the source code.