Skip to content

Commit

Permalink
Merge pull request #9 from ericdbarry/bugfix/#37_posting_url_not_correct
Browse files Browse the repository at this point in the history 
awslabs#37 - fixing tests and adding in two new ones to deal with action pos…
  • Loading branch information
@ericdbarry
ericdbarry authored Aug 2, 2019
2 parents 3cc3756 + 46d6b16 commit cf4abb9
Showing 1 changed file with 67 additions and 12 deletions.
79 changes: 67 additions & 12 deletions tests/unit/test_saml.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -196,15 +196,34 @@ def test_non_https_url(self, generic_auth, mock_requests_session,
# The error is raised after the call to get the form, but before the
# call to submit it.
mock_requests_session.get.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=login_form
spec=requests.Response, status_code=200, text=login_form,
url='http://example.com'
)

with pytest.raises(SAMLError, match='HTTPS'):
generic_auth.retrieve_saml_assertion(config)

def test_endpoint_form_redirect_url(self, generic_auth, generic_config,
login_form, mock_requests_session):
mock_requests_session.get.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=login_form,
url='https://test.com'
)
mock_requests_session.post.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=(
'<form><input name="SAMLResponse" '
'value="fakeassertion"/></form>'
)
)
generic_auth.retrieve_saml_assertion(generic_config)
url_used = mock_requests_session.post.call_args[0][0]
assert url_used == "https://test.com/login"

def test_form_action_appended_to_url(self, generic_auth, generic_config,
login_form, mock_requests_session):
mock_requests_session.get.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=login_form
spec=requests.Response, status_code=200, text=login_form,
url='https://example.com'
)
mock_requests_session.post.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=(
Expand All @@ -216,10 +235,37 @@ def test_form_action_appended_to_url(self, generic_auth, generic_config,
url_used = mock_requests_session.post.call_args[0][0]
assert url_used == "https://example.com/login"

def test_form_action_replaces_url(self, generic_auth, generic_config,
login_form, mock_requests_session):
saml_form = (
'<html>'
'<form action="https://www.test.com">'
'<input name="spam"/>'
'<input name="username"/>'
'<input name="password"/>'
'</form>'
'</html>'
)

mock_requests_session.get.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=saml_form,
url='https://example.com'
)
mock_requests_session.post.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=(
'<form><input name="SAMLResponse" '
'value="fakeassertion"/></form>'
)
)
generic_auth.retrieve_saml_assertion(generic_config)
url_used = mock_requests_session.post.call_args[0][0]
assert url_used == "https://www.test.com"

def test_extract_assertion(self, generic_auth, mock_requests_session,
generic_config, login_form):
mock_requests_session.get.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=login_form
spec=requests.Response, status_code=200, text=login_form,
url='https://example.com'
)
mock_requests_session.post.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=(
Expand Down Expand Up @@ -248,7 +294,8 @@ def test_passes_in_other_form_fields(self, generic_auth, generic_config,
'</html>'
)
mock_requests_session.get.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=saml_form
spec=requests.Response, status_code=200, text=saml_form,
url='https://example.com'
)
mock_requests_session.post.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=(
Expand Down Expand Up @@ -280,7 +327,8 @@ def tests_uses_default_form_values(self, generic_auth, generic_config,
'</html>'
)
mock_requests_session.get.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=saml_form
spec=requests.Response, status_code=200, text=saml_form,
url='https://example.com'
)
mock_requests_session.post.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=(
Expand Down Expand Up @@ -384,7 +432,8 @@ def test_missing_form_username(self, generic_auth, mock_requests_session,
'</form></html>'
)
mock_requests_session.get.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=missing_form_fields
spec=requests.Response, status_code=200, text=missing_form_fields,
url='https://example.com'
)
with pytest.raises(SAMLError, match='could not find'):
generic_auth.retrieve_saml_assertion(generic_config)
Expand All @@ -397,7 +446,8 @@ def test_missing_form_password(self, generic_auth, mock_requests_session,
'</form></html>'
)
mock_requests_session.get.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=missing_form_fields
spec=requests.Response, status_code=200, text=missing_form_fields,
url='https://example.com'
)
mock_requests_session.post.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=(
Expand All @@ -422,7 +472,8 @@ def test_missing_form_password(self, generic_auth, mock_requests_session,
def test_empty_assertion(self, generic_auth, mock_requests_session,
login_form, generic_config, assertion_response):
mock_requests_session.get.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=login_form
spec=requests.Response, status_code=200, text=login_form,
url='https://example.com'
)
mock_requests_session.post.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=assertion_response
Expand All @@ -433,7 +484,8 @@ def test_empty_assertion(self, generic_auth, mock_requests_session,
def test_non_200_authenticate_response(self, generic_auth, generic_config,
mock_requests_session, login_form):
mock_requests_session.get.return_value = mock.Mock(
spec=requests.Response, text=login_form, status_code=200
spec=requests.Response, text=login_form, status_code=200,
url='https://example.com'
)

# This 401 response represents an auth failure, such as a bad password.
Expand All @@ -449,7 +501,8 @@ def test_non_200_authenticate_response(self, generic_auth, generic_config,
def test_no_saml_assertion_in_response(self, generic_auth, generic_config,
mock_requests_session, login_form):
mock_requests_session.get.return_value = mock.Mock(
spec=requests.Response, text=login_form, status_code=200
spec=requests.Response, text=login_form, status_code=200,
url='https://example.com'
)
mock_requests_session.post.return_value = mock.Mock(
spec=requests.Response, text='<html>login failed</html>',
Expand Down Expand Up @@ -489,7 +542,8 @@ def test_authn_requests_made(self, okta_auth, okta_config,
mock_requests_session.get.return_value = mock.Mock(
text=('<form><input name="SAMLResponse" '
'value="fakeassertion"/></form>'),
status_code=200
status_code=200,
url='https://example.com'
)
saml_assertion = okta_auth.retrieve_saml_assertion(okta_config)
assert saml_assertion == 'fakeassertion'
Expand Down Expand Up @@ -543,7 +597,8 @@ def test_uses_adfs_fields(self, adfs_auth, mock_requests_session,
'</html>'
)
mock_requests_session.get.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=adfs_login_form
spec=requests.Response, status_code=200, text=adfs_login_form,
url='https://example.com'
)
mock_requests_session.post.return_value = mock.Mock(
spec=requests.Response, status_code=200, text=(
Expand Down

0 comments on commit cf4abb9

Please sign in to comment.