Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zundel/test GitHub review #18

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Commits on Oct 18, 2016

  1. Adding scalafmt formatting to fmt goal

    Adds scalafmt formatting to the fmt command for scala files.
    
    Refactored ScalaFmt class into a base class, with two sub classes ScalaFmtCheckFormat (checks if files are formatted correctly) and ScalaFmtFormat (formats the files).  This ensures that the same version of scalafmt is used for both.
    
    Both of these are currently turned off in pants.ini. Skip=True
    
    Testing Done:
    New Integration Test Case
    CI passes [pantsbuild#3936](pantsbuild#3963)
    
    Reviewed at https://rbcommons.com/s/twitter/r/4312/
    Caitie McCaffrey authored and stuhood committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    0779a82 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2016

  1. Prepare 1.2.0rc2 release

    As described in the [updated release docs](http://www.pantsbuild.org/release.html#preparation-for-the-release-from-the-stable-branch), this review adds the 1.2.0rc2 notes in master, which will then be cherry-picked and released from the `1.2.x` branch.
    
    - Update the release notes for a 1.2.0rc2 release.
    
    Testing Done:
    https://travis-ci.org/pantsbuild/pants/builds/168717837
    
    Reviewed at https://rbcommons.com/s/twitter/r/4326/
    stuhood committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    0e43562 View commit details
    Browse the repository at this point in the history
  2. Add a target-types option to scalafmt to avoid formatting all targets

    - Add and use a target-types option to avoid formatting all targets.
    - Fix output of suggested `./pants fmt` command.
    
    Testing Done:
    https://travis-ci.org/pantsbuild/pants/builds/169065521
    
    Bugs closed: 3957, 3990
    
    Reviewed at https://rbcommons.com/s/twitter/r/4328/
    stuhood committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    e80c77b View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2016

  1. Prepare 1.2.0rc3

    Prepare the 1.2.0rc3 release. As with 1.2.0rc2, the actual release will go out from the `1.2.x` branch.
    
    Testing Done:
    https://travis-ci.org/pantsbuild/pants/builds/169095919
    
    Reviewed at https://rbcommons.com/s/twitter/r/4329/
    stuhood committed Oct 20, 2016
    Configuration menu
    Copy the full SHA
    02dd187 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a022b9 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2016

  1. Fix the SetupPy target ownership check.

    Previously the check was too restrictive and considered targets that did
    not own files when the single publish ownership check is only intended
    to prevent publishing the same file in more than one package.
    
    Testing Done:
    Tested this over in Aurora ad-hoc and it solved the publish problem
    there as well as passing the new test emulating the Aurora `prep_command`
    arrangement.
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/169610485
    
    Bugs closed: 3968, 3969
    
    Reviewed at https://rbcommons.com/s/twitter/r/4315/
    jsirois committed Oct 22, 2016
    Configuration menu
    Copy the full SHA
    0abade1 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2016

  1. bogus fix for issue 261

    ericzundel committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    28bbb0f View commit details
    Browse the repository at this point in the history