forked from pantsbuild/pants
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zundel/test GitHub review #18
Open
ericzundel
wants to merge
7
commits into
master
Choose a base branch
from
zundel/test-github-review
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Oct 18, 2016
-
Adding scalafmt formatting to fmt goal
Adds scalafmt formatting to the fmt command for scala files. Refactored ScalaFmt class into a base class, with two sub classes ScalaFmtCheckFormat (checks if files are formatted correctly) and ScalaFmtFormat (formats the files). This ensures that the same version of scalafmt is used for both. Both of these are currently turned off in pants.ini. Skip=True Testing Done: New Integration Test Case CI passes [pantsbuild#3936](pantsbuild#3963) Reviewed at https://rbcommons.com/s/twitter/r/4312/
Configuration menu - View commit details
-
Copy full SHA for 0779a82 - Browse repository at this point
Copy the full SHA 0779a82View commit details
Commits on Oct 19, 2016
-
As described in the [updated release docs](http://www.pantsbuild.org/release.html#preparation-for-the-release-from-the-stable-branch), this review adds the 1.2.0rc2 notes in master, which will then be cherry-picked and released from the `1.2.x` branch. - Update the release notes for a 1.2.0rc2 release. Testing Done: https://travis-ci.org/pantsbuild/pants/builds/168717837 Reviewed at https://rbcommons.com/s/twitter/r/4326/
Configuration menu - View commit details
-
Copy full SHA for 0e43562 - Browse repository at this point
Copy the full SHA 0e43562View commit details -
Add a target-types option to scalafmt to avoid formatting all targets
- Add and use a target-types option to avoid formatting all targets. - Fix output of suggested `./pants fmt` command. Testing Done: https://travis-ci.org/pantsbuild/pants/builds/169065521 Bugs closed: 3957, 3990 Reviewed at https://rbcommons.com/s/twitter/r/4328/
Configuration menu - View commit details
-
Copy full SHA for e80c77b - Browse repository at this point
Copy the full SHA e80c77bView commit details
Commits on Oct 20, 2016
-
Prepare the 1.2.0rc3 release. As with 1.2.0rc2, the actual release will go out from the `1.2.x` branch. Testing Done: https://travis-ci.org/pantsbuild/pants/builds/169095919 Reviewed at https://rbcommons.com/s/twitter/r/4329/
Configuration menu - View commit details
-
Copy full SHA for 02dd187 - Browse repository at this point
Copy the full SHA 02dd187View commit details -
Deprecate the
java_tests
alias in favor ofjunit_tests
.Testing Done: CI passed: https://travis-ci.org/pantsbuild/pants/builds/168784588 Reviewed at https://rbcommons.com/s/twitter/r/4322/
Configuration menu - View commit details
-
Copy full SHA for 3a022b9 - Browse repository at this point
Copy the full SHA 3a022b9View commit details
Commits on Oct 22, 2016
-
Fix the SetupPy target ownership check.
Previously the check was too restrictive and considered targets that did not own files when the single publish ownership check is only intended to prevent publishing the same file in more than one package. Testing Done: Tested this over in Aurora ad-hoc and it solved the publish problem there as well as passing the new test emulating the Aurora `prep_command` arrangement. CI went green here: https://travis-ci.org/pantsbuild/pants/builds/169610485 Bugs closed: 3968, 3969 Reviewed at https://rbcommons.com/s/twitter/r/4315/
Configuration menu - View commit details
-
Copy full SHA for 0abade1 - Browse repository at this point
Copy the full SHA 0abade1View commit details
Commits on Oct 24, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 28bbb0f - Browse repository at this point
Copy the full SHA 28bbb0fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.