core: use blst from evmone #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
ci/deps_blst
branch
4 times, most recently
from
ba58364 to
4d36717
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2245 +/- ##
==========================================
+ Coverage 52.85% 52.88% +0.02%
==========================================
Files 728 728
Lines 49932 49932
Branches 7570 7570
==========================================
+ Hits 26392 26405 +13
+ Misses 21221 21208 -13
Partials 2319 2319 ☔ View full report in Codecov by Sentry. |
13 tasks
|
This was an illustration and test to show that evmone's integration of blst can be propagated to silkworm. The difference is that evmone uses CMake ExternalProject to get the sources instead of git submodule. Do you think this is fine for you? |
chfast
force-pushed
the
ci/deps_blst
branch
from
39e691e to
b6eea35
Compare
chfast
force-pushed
the
evmone/v0.13
branch
2 times, most recently
from
79726c9 to
793fbb7
Compare
chfast
commented
Oct 8, 2024
| IMPORTED_LOCATION ${BLST_DIR}/${BLST_LIB} | ||
| ) | ||
| # cmake-format: on | ||
| include(../evmone/evmone/cmake/blst.cmake) |
There was a problem hiding this comment.
This is to minimize number of changes in Silkworm, but we can also remove this file and include evmone/cmake/blst.cmake directly.
canepat
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse evmone's configuration for blst dependency.