Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompiles: Prepare blst dependency #972

Merged
merged 1 commit into from
Aug 27, 2024
Merged

precompiles: Prepare blst dependency #972

merged 1 commit into from
Aug 27, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Aug 13, 2024

Configure blst dependency using CMake's ExternalProject.

This has been tested here (#979) and in Silkworm (erigontech/silkworm#2245).

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (2d20cc6) to head (256194b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #972   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files         143      143           
  Lines       16148    16148           
=======================================
  Hits        15227    15227           
  Misses        921      921           
Flag Coverage Δ
eof_execution_spec_tests 16.67% <ø> (ø)
ethereum_tests 26.57% <ø> (ø)
ethereum_tests_silkpre 18.67% <ø> (ø)
execution_spec_tests 17.71% <ø> (ø)
unittests 89.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chfast chfast force-pushed the precompiles/blst branch 3 times, most recently from c9ec811 to 41f3d35 Compare August 16, 2024 12:12
Configure blst dependency using CMake's ExternalProject.
@chfast chfast changed the title precompiles: Implement KZG proof verification (aka "point evaluation") precompiles: Prepare blst dependency Aug 26, 2024
@chfast chfast marked this pull request as ready for review August 26, 2024 18:51
@chfast chfast added the precompiles Related to EVM precompiles label Aug 26, 2024
@chfast chfast requested review from gumb0 and rodiazet August 26, 2024 18:51
@chfast chfast merged commit 6caebac into master Aug 27, 2024
25 checks passed
@chfast chfast deleted the precompiles/blst branch August 27, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
precompiles Related to EVM precompiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants