ci: fail clang-tidy job on threshold #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battlmonstr
force-pushed
the
pr/tidy_threshold
branch
12 times, most recently
from
08b96e8 to
c24b8dd
Compare
battlmonstr
force-pushed
the
pr/tidy_threshold
branch
from
c24b8dd to
b36cc4a
Compare
battlmonstr
force-pushed
the
pr/tidy_threshold
branch
from
b36cc4a to
4f5dc4d
Compare
This reverts commit 4f5dc4d.
canepat
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings can slip through the clang-tidy-diff job on PRs, because it has a limited time budget (1 min per .cpp file) and not checking .hpp files (#2479). If it happens we don't want to immediately treat master as "broken" on the basis of a few clang-tidy "nits" (and be forced to rush with quick fixes for the nits to make master "green" again).
This PR makes clang-tidy CI job advisory until it reaches N warnings.
example report