Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fail clang-tidy job on threshold #2505

Merged
merged 3 commits into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ commands:
command: |
if [[ <<parameters.ethereum_tests>> == false ]]
then
git config submodule.ethereum-tests.update none
git config submodule.ethereum-tests.update none
fi

git submodule sync
Expand Down Expand Up @@ -71,12 +71,13 @@ commands:
cmake ../project -DCMAKE_BUILD_TYPE=<<parameters.build_type>> $CONAN_CMAKE_ARGS $TOOLCHAIN_CMAKE_ARGS $BUILD_CMAKE_ARGS
- run:
name: "Build"
command: |
working_directory: ~/build
command: |
if [[ "<<parameters.target>>" == "all" ]]
then
cmake --build ~/build -j16
cmake --build . -j16 |& tee build.log
else
cmake --build ~/build -j16 --target <<parameters.target>>
cmake --build . -j16 --target <<parameters.target>> |& tee build.log
fi

install_conan:
Expand Down Expand Up @@ -344,6 +345,9 @@ jobs:
build_type: Debug
compiler_id: clang
compiler_version: <<pipeline.parameters.clang_version_latest>>
- run:
name: "Report"
command: tools/lint/clang_tidy_report.sh "$HOME/build/build.log"

linux-clang-tidy-diff:
environment:
Expand Down
2 changes: 1 addition & 1 deletion .clang-tidy
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FormatStyle: file
HeaderFilterRegex: 'silkworm/(capi|core|db|execution|infra|node|rpc|sentry|sync|wasm)/.+\.hpp$'
WarningsAsErrors: '*'
WarningsAsErrors: 'bugprone-use-after-move'
Checks: >
abseil-*,
boost-*,
Expand Down
23 changes: 0 additions & 23 deletions third_party/clang-tidy-html/LICENSE

This file was deleted.

Loading
Loading