Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EVMC refund calculation #749

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Conversation

gumb0
Copy link
Contributor

@gumb0 gumb0 commented Sep 2, 2022

No description provided.

@gumb0 gumb0 force-pushed the evmc-refunds branch 3 times, most recently from 0eb8630 to 3c70fa4 Compare September 5, 2022 14:41
@gumb0
Copy link
Contributor Author

gumb0 commented Sep 6, 2022

Bug in evmone discovered ethereum/evmone#504

@gumb0 gumb0 force-pushed the evmc-refunds branch 3 times, most recently from 2a5cff7 to 2898bf3 Compare September 6, 2022 14:05
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #749 (bbd225e) into master (7f5cda3) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head bbd225e differs from pull request most recent head f369b3b. Consider uploading reports for the commit f369b3b to get more accurate results

@@            Coverage Diff             @@
##           master     #749      +/-   ##
==========================================
- Coverage   76.21%   76.15%   -0.06%     
==========================================
  Files         193      193              
  Lines       13700    13674      -26     
  Branches     2188     2180       -8     
==========================================
- Hits        10441    10413      -28     
- Misses       2349     2352       +3     
+ Partials      910      909       -1     
Impacted Files Coverage Δ
core/silkworm/execution/evm.hpp 80.00% <ø> (ø)
core/silkworm/execution/processor.hpp 66.66% <ø> (ø)
core/silkworm/state/intra_block_state.cpp 95.34% <ø> (-0.09%) ⬇️
core/silkworm/state/intra_block_state.hpp 66.66% <ø> (-19.05%) ⬇️
core/silkworm/execution/evm.cpp 93.85% <100.00%> (-0.24%) ⬇️
core/silkworm/execution/processor.cpp 85.36% <100.00%> (-0.47%) ⬇️
node/silkworm/rpc/server/call.hpp 70.28% <0.00%> (-0.86%) ⬇️
core/silkworm/types/block.cpp 87.00% <0.00%> (-0.50%) ⬇️
core/silkworm/consensus/pos/engine.cpp 83.33% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

core/silkworm/execution/evm.cpp Outdated Show resolved Hide resolved
core/silkworm/execution/evm.cpp Outdated Show resolved Hide resolved
@chfast chfast marked this pull request as ready for review September 7, 2022 13:01
@gumb0 gumb0 requested a review from yperbasis September 7, 2022 17:11
@yperbasis yperbasis merged commit 3ce6638 into erigontech:master Sep 8, 2022
@gumb0 gumb0 deleted the evmc-refunds branch September 8, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants