Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset gas refund counter in ExecutionState #504

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Sep 6, 2022

No description provided.

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #504 (9f80ae4) into master (4ab4b4b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files          53       53           
  Lines        5260     5264    +4     
=======================================
+ Hits         5229     5233    +4     
  Misses         31       31           
Flag Coverage Δ
blockchaintests 77.86% <ø> (ø)
statetests 7.57% <0.00%> (-0.01%) ⬇️
unittests 99.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/evmone/execution_state.hpp 94.73% <100.00%> (+0.09%) ⬆️
test/unittests/execution_state_test.cpp 100.00% <100.00%> (ø)

@gumb0 gumb0 requested review from yperbasis, axic and chfast September 6, 2022 13:50
@chfast
Copy link
Member

chfast commented Sep 6, 2022

We may want to release this as 0.9.1 so if you don't mind the trouble, you can create release/0.9 branch at v0.9.0 and merge it there. Also add changelog entry.

@gumb0 gumb0 merged commit 524ce6b into master Sep 7, 2022
@gumb0 gumb0 deleted the gas-refund-reset branch September 7, 2022 10:24
gumb0 added a commit that referenced this pull request Sep 7, 2022
Reset gas refund counter in ExecutionState
gumb0 added a commit that referenced this pull request Sep 7, 2022
Reset gas refund counter in ExecutionState
gumb0 pushed a commit that referenced this pull request Sep 7, 2022
Reset gas refund counter in ExecutionState
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants