Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable dirty-scheduler on default erlang image #29

Closed
c0b opened this issue Nov 7, 2016 · 5 comments · Fixed by #34
Closed

enable dirty-scheduler on default erlang image #29

c0b opened this issue Nov 7, 2016 · 5 comments · Fixed by #34

Comments

@c0b
Copy link
Collaborator

c0b commented Nov 7, 2016

I just found a comment on the docker hub page https://hub.docker.com/_/erlang/

radupopescu 18 days ago
Hello,
Would it be possible to enable dirty schedulers for 19, 19.1, latest images?

and researched somewhat for benefits why need dirty scheduler and how to do that

https://news.ycombinator.com/item?id=11064763
https://hamidreza-s.github.io/erlang/scheduling/real-time/preemptive/migration/2016/02/09/erlang-scheduler-details.html

http://erlang.org/doc/installation_guide/INSTALL.html#Advanced-configuration-and-build-of-ErlangOTP_Configuring

--enable-dirty-schedulers - Enable the experimental dirty schedulers functionality. Note that the dirty schedulers functionality is experimental, and not supported. This functionality will be subject to backward incompatible changes. Note that you should not enable the dirty scheduler functionality on production systems. It is only provided for testing. This switch also imply --enable-new-purge-strategy (see below).

the good news is this feature would be an easy one https://github.com/c0b/docker-erlang-otp/blob/master/19/Dockerfile#L24 just need some sanity check before releasing in the new way of building 19+ images

(generally a github issue for feature request is preferred over docker hub comment, because hub.docker.com doesn't have comments notification and many other features as a discussion board should have)

c0b added a commit that referenced this issue Nov 15, 2016
also --enable-dirty-schedulers will become default for #29 for Erlang19.
c0b added a commit that referenced this issue Nov 15, 2016
also --enable-dirty-schedulers will become default for #29 for Erlang19.
@c0b
Copy link
Collaborator Author

c0b commented Nov 15, 2016

c0b added a commit that referenced this issue Nov 15, 2016
also --enable-dirty-schedulers will become default for #29 for Erlang19.
@radupopescu
Copy link

Thanks for the links and for updating the image. Waiting for #29.

About the dockerhub comments, understood.

@radupopescu
Copy link

Hi there,

I was wondering if you know when this will be merged? Having dirty schedulers enabled in the Erlang 19 image would greatly simplify my other image(s).

Thanks!

@c0b
Copy link
Collaborator Author

c0b commented Dec 9, 2016

sorry didn't have a chance to update, while doing #32 I did some local test of enabled dirty scheduler, it works without too much effort; so another PR to enable dirty scheduler should be there shortly

@radupopescu
Copy link

Hi!

This is great to hear. Looking forward to trying out the new image.

Thanks!

c0b added a commit that referenced this issue Dec 10, 2016
- add support for observer as the most popular wx GUI based app
  for #28; image size increased ~65MB.

    REPOSITORY    TAG                   IMAGE ID      CREATED             SIZE
    otp           20.0-rc0-cd48b81-wx   f8b3e0fc15dd  49 seconds ago      814.9 MB
    otp           20.0-rc0-cd48b81      dbff7d029fed  About an hour ago   749.9 MB

- also support dirty scheduler for #29;

- temporarily disable compiling rebar3
  because it fail bootstrap on Erlang 20; see more in erlang/rebar3#1414
c0b added a commit that referenced this issue Dec 10, 2016
c0b added a commit that referenced this issue Dec 15, 2016
- add wxwidgets for observer and other wx / tk based apps (fixes #28);
- the dirty scheduler (fixes #29)
c0b added a commit that referenced this issue Dec 15, 2016
- add wxwidgets for observer and other wx / tk based apps (fixes #28);
- the dirty scheduler (fixes #29)
@c0b c0b mentioned this issue Dec 15, 2016
@c0b c0b closed this as completed in #34 Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants