./bootstrap failed on Erlang 20; because of erlware_commons dependency

[c0b]

trying to build rebar3.3.3 with Erlang20 failed on bootstrap; the DEBUG=1 here seems not making a difference?

root@59e86c41a37b:/usr/src/rebar3-src# HOME=$PWD DEBUG=1 ./bootstrap
/usr/src/rebar3-src/_build/default/lib/erlware_commons/src/ec_semver_parser.erl:15: Warning: export_all flag enabled - all functions will be exported

root@59e86c41a37b:/usr/src/rebar3-src# echo $?
1
root@59e86c41a37b:/usr/src/rebar3-src# HOME=$PWD DEBUG=1 ./bootstrap
Dependency providers already exists
Dependency getopt already exists
Dependency cf already exists
Dependency erlware_commons already exists
/usr/src/rebar3-src/_build/default/lib/erlware_commons/src/ec_semver_parser.erl:15: Warning: export_all flag enabled - all functions will be exported

root@59e86c41a37b:/usr/src/rebar3-src# echo $?
1

with Erlang19 it seems fine. but similar to #1122 it seems erlware_commons lagged behind

[talentdeficit]

that export_all warning is probably new. you can test rebar3 on 20 by removing this from the config

[c0b]

how about make another environment variable to let warnings_as_errors depends on? would be easier to debug warnings vs real errors

[talentdeficit]

it'd be pretty easy to add that to the compiler. i won't have time for a while but if you'd like to tackle it this is where you'd want to alter the options passed to the erlang compiler to eliminate warnings_as_errors

i'd be happy to help if you need any guidance

[ferd]

We should probably just fix the dependencies for this case though.

[talentdeficit]

fixed in #1439

further discussion of disabling warnings_as_errors can take place in #1438