Bad ETag handling in rebar_pkg_resource #1741
Labels
bug
enhancement
new behaviour or additional functionality
help wanted
unlikely to be tackled by core maintainers
The following line in rebar_pkg_resource
rebar3/src/rebar_pkg_resource.erl
Line 112 in d6cec1a
sends out the request to the hexpm server. Here the ETag variable contains a string, which goes through httpc.
Unfortunately the 'if-none-match' field when arriving on the other side does not contain quotes. The specification for this field says it should be quoted. References:
https://tools.ietf.org/html/rfc2616#page-132
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-None-Match
Because of this I suggest this line should look like this:
The reason why we need this modification is that we have implemented a hexpm server,
which used cowboy1 where handling values without quotes in header values was possible but now
we can't do the same as we started using cowboy2 some weeks ago which complains about bad header format.
The text was updated successfully, but these errors were encountered: