-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ETags should be stored in rebar_pkg_resource #1743
Comments
It should be cheaper to run than the current thing, even though the bottleneck will remain the hash check. I don't have much of a problem with caching the etag, though I would probably store them as file pairs rather than one big etag file + 50 packages. I.e. package-vsn.tgz + package-vsn.etag ? |
I have created this PR: |
The return values in rebar_pkg_resource were a bit confusing for me, so I have created an other pull request containing some type specs for the module: https://github.com/erlang/rebar3/pull/1746/commits |
All merged. |
Currently ETags are calculated from the pkg file stored locally, which is wrong.
As mentioned by @ericmj in previous issue: #1741, the ETags
sent back from the hex server should be stored together with the downloaded pkg files.
A possible solution is to store etags in a .eterm file in ~/.cache/rebar3/hex/default/packages/pkg_etags.eterm in proplist format.
What do you think about this solution?
The text was updated successfully, but these errors were encountered: