-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --relnames option to allow selectively building of multiple releases #2630
Conversation
I wanted to add a test case but didn't find a good place where this is tested e2e. What is your suggestion? |
@TheGeorge you can send a test to https://github.com/tsloughter/rebar3_tests/ if you think that fits it better (which it probably does in this case). You can either create a new project in it or use one of the existing ones that builds a release and add a step in the |
src/rebar_relx.erl
Outdated
XrefIgnores = rebar_state:get(State, xref_ignores, []), | ||
RelxState = rlx_state:filter_xref_warning(RelxState_0, | ||
fun(Warnings) -> | ||
rebar_prv_xref:filter_xref_results(undefined_function_calls, XrefIgnores, Warnings) end), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were these removed?
Wuuups that's a copy paste error, I should have checked the diff before
submitting.
…On Wed, Oct 27, 2021, 17:25 Tristan Sloughter ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/rebar_relx.erl
<#2630 (comment)>:
> - XrefIgnores = rebar_state:get(State, xref_ignores, []),
- RelxState = rlx_state:filter_xref_warning(RelxState_0,
- fun(Warnings) ->
- rebar_prv_xref:filter_xref_results(undefined_function_calls, XrefIgnores, Warnings) end),
Why were these removed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2630 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACHLD7UKDSQNPMRR75SS3DUJARWRANCNFSM5G2JILXQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Ah nice! Thanks!!
…On Wed, Oct 27, 2021, 17:24 Tristan Sloughter ***@***.***> wrote:
@TheGeorge <https://github.com/TheGeorge> you can send a test to
https://github.com/tsloughter/rebar3_tests/ if you think that fits it
better (which it probably does in this case). You can either create a new
project in it or use one of the existing ones that builds a release and add
a step in the .test file that uses --relnames.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2630 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACHLD4REVASYFJCV25U6JTUJARSVANCNFSM5G2JILXQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@tsloughter I made a PR with tests here: tsloughter/rebar3_tests#10 They succeed with the rebar3 produced from this pr:
|
@tsloughter @ferd |
Sorry about that. |
We have a use-case where we have alot of releases in an umbrella project. Building all releases takes a long time, and usually we only need a selected hand full. However, building them one at a time is also slow.
The release provider has already the functionality to build releases in parallel. This PR adds a --relnames option the works like --all in that it builds the highest version, but it takes a list of release names.
e.g.
If a release is not found, it fails on the first release, and does not start building any release: