Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for release provider testing --all and --relnames options #10

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

TheGeorge
Copy link

@TheGeorge TheGeorge commented Nov 2, 2021

Tests for change proposed in erlang/rebar3#2630

+ shelltest -c --diff --all --execdir releases_test/releases.test
:releases_test/releases.test:1: [OK]
:releases_test/releases.test:2: [OK]
:releases_test/releases.test:3: [OK]
:releases_test/releases.test:4: [OK]

         Test Cases  Total
 Passed  4           4
 Failed  0           0
 Total   4           4

A local test succeeds on those tests

rebar3 release
>>>= 1
rebar3 release --relname app1
>>>= 0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but just to be sure can you add a test to verify the release is built, like:

ls _build/default/rel/app1/releases
>>>= 0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, makes a lot of sense!

@@ -0,0 +1,8 @@
rebar3 release
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a check that the output includes the expected error message:

Must specify the name of the release to build when there are multiple releases in the config

@tsloughter tsloughter merged commit f2e7d48 into tsloughter:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants