Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to set logging level #7

Merged
merged 5 commits into from
Aug 23, 2021
Merged

Add function to set logging level #7

merged 5 commits into from
Aug 23, 2021

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Aug 5, 2021

Merge #5 first

  • Set default loglevel to info
  • Added function to set loglevel
  • Improved logging in run_training
  • Cleaned up notebook

gomezzz added 2 commits August 5, 2021 17:50
@gomezzz
- Set default loglevel to info
6100449 
- Added function to set loglevel
- Improved logging in run_training
- Cleaned up notebook
@gomezzz
Merge branch 'main' into Add-function-to-set-logging-level
b97206c
@gomezzz gomezzz requested a review from htoftevaag August 5, 2021 15:52
@gomezzz gomezzz mentioned this pull request Aug 5, 2021
Merged
gomezzz
gomezzz commented Aug 6, 2021
View reviewed changes
nidn/utils/set_log_level.py Outdated Show resolved Hide resolved
htoftevaag
htoftevaag reviewed Aug 23, 2021
View reviewed changes
Copy link
Collaborator

@htoftevaag htoftevaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggested changes

nidn/materials/material_collection.py Outdated Show resolved Hide resolved
nidn/materials/material_collection.py Outdated Show resolved Hide resolved
nidn/tests/material_collection_test.py Outdated Show resolved Hide resolved
nidn/tests/material_collection_test.py Outdated Show resolved Hide resolved
nidn/training/model/model_to_eps_grid.py Show resolved Hide resolved
nidn/training/run_training.py Outdated Show resolved Hide resolved
nidn/training/run_training.py Outdated Show resolved Hide resolved
nidn/training/run_training.py Outdated Show resolved Hide resolved
nidn/utils/set_log_level.py Outdated Show resolved Hide resolved
nidn/utils/set_log_level.py Outdated Show resolved Hide resolved
gomezzz and others added 2 commits August 23, 2021 10:56
@gomezzz @htoftevaag
Apply suggestions from code review
75c0acd 
Co-authored-by: Håvard Hem Toftevaag <70584234+htoftevaag@users.noreply.github.com>
@gomezzz
Merge branch 'main' into Add-function-to-set-logging-level
5a34960
htoftevaag
htoftevaag approved these changes Aug 23, 2021
View reviewed changes
Copy link
Collaborator

@htoftevaag htoftevaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@htoftevaag htoftevaag merged commit ca95978 into main Aug 23, 2021
@htoftevaag htoftevaag deleted the Add-function-to-set-logging-level branch August 23, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htoftevaag htoftevaag htoftevaag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomezzz @htoftevaag