Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readd classification network #5

Merged
merged 6 commits into from
Aug 23, 2021
Merged

Readd classification network #5

merged 6 commits into from
Aug 23, 2021

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Aug 5, 2021

First merge #2 #3 #4

  • Added material collection and a test for it
  • Added some materials
  • Added material collection in several places
  • Removed outfeatures from cfg
  • Added model type to cfg
  • Fixed bug in NERF
  • Added classification model type to grid gen and training
    -Fixed oversampling
  • Refactored training
  • Added treatment of NaNs (fall back on previous model)
  • Minor changes in notebook

gomezzz added 4 commits August 5, 2021 12:08
@gomezzz
- Added material collection and a test for it
c3d01c5 
- Added some materials
@gomezzz
- Added material collection in several places
9ca75c4 
- Removed outfeatures from cfg
- Added model type to cfg
- Fixed bug in NERF
- Added classification model type to grid gen and training
-Fixed oversampling
- Refactored training
- Added treatment of NaNs (fall back on previous model)
@gomezzz
- Minor changes in notebook
83eaec7
@gomezzz
Merge branch 'main' into Readd-classification-network
2ae33d8
@gomezzz gomezzz requested a review from htoftevaag August 5, 2021 14:10
@gomezzz gomezzz changed the base branch from main to Create-RtD August 5, 2021 15:42
@gomezzz gomezzz changed the base branch from Create-RtD to main August 5, 2021 15:42
@gomezzz gomezzz mentioned this pull request Aug 5, 2021
Merged
htoftevaag
htoftevaag requested changes Aug 5, 2021
View reviewed changes
Copy link
Collaborator

@htoftevaag htoftevaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggested changes

nidn/training/model/model_to_eps_grid.py Outdated Show resolved Hide resolved
nidn/training/run_training.py Outdated Show resolved Hide resolved
nidn/training/run_training.py Outdated Show resolved Hide resolved
@gomezzz gomezzz mentioned this pull request Aug 5, 2021
Merged
@gomezzz @htoftevaag
Apply suggestions from code review
5a170f3 
Co-authored-by: Håvard Hem Toftevaag <70584234+htoftevaag@users.noreply.github.com>
@gomezzz gomezzz requested a review from htoftevaag August 5, 2021 16:25
@gomezzz gomezzz mentioned this pull request Aug 5, 2021
Merged
htoftevaag
htoftevaag approved these changes Aug 23, 2021
View reviewed changes
Copy link
Collaborator

@htoftevaag htoftevaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@htoftevaag htoftevaag merged commit 9d2ca6d into main Aug 23, 2021
@htoftevaag htoftevaag deleted the Readd-classification-network branch August 23, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htoftevaag htoftevaag htoftevaag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomezzz @htoftevaag