Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get frequency points for easy spectrum specification #3

Merged

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Aug 5, 2021

Merge #1 and #2 first

  • Added function to get frequency points
  • Added function to print cfg

Looks like this
image

gomezzz and others added 17 commits August 3, 2021 11:58
- Added some trcwa stuff and constants
Co-authored-by: Håvard Hem Toftevaag <70584234+htoftevaag@users.noreply.github.com>
Co-authored-by: Håvard Hem Toftevaag <70584234+htoftevaag@users.noreply.github.com>
Co-authored-by: Håvard Hem Toftevaag <70584234+htoftevaag@users.noreply.github.com>
Co-authored-by: Håvard Hem Toftevaag <70584234+htoftevaag@users.noreply.github.com>
- Added test for trcwa
- Added some logging and asserts
- Renamed constants due to import behavior
- Some minor fixes
- Finalized backend removal from trcwa
- Cleaned up import mess
- Added test for frequency conversion
- Training NB WIP
- Started adding a function to validate cfgs
- Reworked plots to work with models
- Added missign cfg params and checks for them
- Made sigmoid def
- Small fixes
- Relocated validate config
- Added function to print cfg
Copy link
Collaborator

@htoftevaag htoftevaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two punctuations.

Could also consider cleaning the print_cfg.py so that the values that go together are displayed together (in the same row/column)

nidn/utils/print_cfg.py Outdated Show resolved Hide resolved
nidn/utils/print_cfg.py Outdated Show resolved Hide resolved
Co-authored-by: Håvard Hem Toftevaag <70584234+htoftevaag@users.noreply.github.com>
@gomezzz gomezzz requested a review from htoftevaag August 5, 2021 12:57
@htoftevaag htoftevaag merged commit 768893b into main Aug 5, 2021
@htoftevaag htoftevaag deleted the add-get-frequency-points-for-easy-spectrum-specification branch August 5, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants